qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Bandan Das <bsd@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PULL 5/7] usb-mtp: fix call to trace function
Date: Fri,  8 Jan 2016 11:40:13 +0100	[thread overview]
Message-ID: <1452249615-8222-6-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1452249615-8222-1-git-send-email-kraxel@redhat.com>

From: Bandan Das <bsd@redhat.com>

trace_usb_mtp_inotify_event() was being called after the object was
being freed.

Signed-off-by: Bandan Das <bsd@redhat.com>
Message-id: 1450861787-16213-3-git-send-email-bsd@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/usb/dev-mtp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index db1fd59..4177a87 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -502,9 +502,9 @@ static void inotify_watchfn(void *arg)
                 entry = g_new0(MTPMonEntry, 1);
                 entry->handle = o->handle;
                 entry->event = EVT_OBJ_REMOVED;
-                usb_mtp_object_free(s, o);
                 trace_usb_mtp_inotify_event(s->dev.addr, o->path,
                                       event->mask, "Obj Deleted");
+                usb_mtp_object_free(s, o);
                 break;
 
             case IN_MODIFY:
-- 
1.8.3.1

  parent reply	other threads:[~2016-01-08 10:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-08 10:40 [Qemu-devel] [PULL 0/7] usb patch queue Gerd Hoffmann
2016-01-08 10:40 ` [Qemu-devel] [PULL 1/7] ohci: split reset method in 3 parts Gerd Hoffmann
2016-01-08 10:40 ` [Qemu-devel] [PULL 2/7] ohci: fix Host Controller USBRESET Gerd Hoffmann
2016-01-08 10:40 ` [Qemu-devel] [PULL 3/7] ohci: fix command HostControllerReset Gerd Hoffmann
2016-01-08 10:40 ` [Qemu-devel] [PULL 4/7] usb-mtp: use safe variant when cleaning events list Gerd Hoffmann
2016-01-08 10:40 ` Gerd Hoffmann [this message]
2016-01-08 10:40 ` [Qemu-devel] [PULL 6/7] ohci: delay first SOF interrupt Gerd Hoffmann
2016-01-08 10:40 ` [Qemu-devel] [PULL 7/7] ohci: clear pending SOF on suspend Gerd Hoffmann
2016-01-08 12:50 ` [Qemu-devel] [PULL 0/7] usb patch queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452249615-8222-6-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=bsd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).