From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51271) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHXkI-0002w7-OT for qemu-devel@nongnu.org; Fri, 08 Jan 2016 09:10:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHXkD-0007In-EB for qemu-devel@nongnu.org; Fri, 08 Jan 2016 09:10:26 -0500 Received: from mailhub.sw.ru ([195.214.232.25]:48585 helo=relay.sw.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHXkD-0007IB-0e for qemu-devel@nongnu.org; Fri, 08 Jan 2016 09:10:21 -0500 From: "Denis V. Lunev" Date: Fri, 8 Jan 2016 17:10:11 +0300 Message-Id: <1452262216-4545-1-git-send-email-den@openvz.org> Subject: [Qemu-devel] [PATCH v4 0/5] QMP wrappers for VM snapshot operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juan Quintela , qemu-devel@nongnu.org, Markus Armbruster , Amit Shah , "Denis V. Lunev" EFI based VM with pflash storage for NVRAM could not be snapshoted as libvirt configures storage as 'raw' and writable. OK, this is a libvirt problem. Another problem is that libvirt can not detect this failure at all as it uses HMP for this operation. This create snapshot/delete snapshot sequence passes silently. The patchset adds QMP wrappers for the purpose. Signed-off-by: "Denis V. Lunev" CC: Juan Quintela CC: Amit Shah CC: Markus Armbruster CC: Eric Blake Changes from v3: - wrong patch 1 is replaced Changes from v2: - patches 1/2 are resplit to move processing HMP specific handling of snapshot name generation to exclusive HMP code - removed all '.' at the end of error_setg strings - fixed too long lines with '-' in qmp-commands.hx - error_setg_errno errno passing is fixed (-ret) - fixed logical error in hmp_loadvm (vm_start on error) - NOT switched to error_prepend code (it is not yet merged). Can we do this later? This will make my life easear merging code to our downstream. Changes from v1: - cosmetic fixes suggested by Markus. I pray I have added all of them - patch 5 is rewritten completely. Original one was deadbeaf Denis V. Lunev (5): migration: split hmp_savevm to migrate_savevm and hmp_savevm wrapper qmp: create qmp_savevm command qmp: create qmp_delvm command migration: improve error reporting for load_vmstate qmp: create QMP implementation of loadvm command hmp.c | 36 +++++++++++++++ include/migration/migration.h | 1 + include/sysemu/sysemu.h | 2 +- migration/savevm.c | 100 +++++++++++++++++++++--------------------- monitor.c | 9 ++-- qapi-schema.json | 39 ++++++++++++++++ qmp-commands.hx | 71 ++++++++++++++++++++++++++++++ vl.c | 4 +- 8 files changed, 206 insertions(+), 56 deletions(-) -- 2.5.0