qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, jsnow@redhat.com
Subject: [Qemu-devel] [PULL 05/11] libqos/ahci: ATAPI identify
Date: Fri,  8 Jan 2016 19:51:52 -0500	[thread overview]
Message-ID: <1452300718-10660-6-git-send-email-jsnow@redhat.com> (raw)
In-Reply-To: <1452300718-10660-1-git-send-email-jsnow@redhat.com>

We need to say "hello!" to our ATAPI friends
in a slightly different manner.

Signed-off-by: John Snow <jsnow@redhat.com>
Message-id: 1452282920-21550-4-git-send-email-jsnow@redhat.com
---
 tests/ahci-test.c   | 8 +++++++-
 tests/libqos/ahci.c | 5 +++++
 tests/libqos/ahci.h | 1 +
 3 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/tests/ahci-test.c b/tests/ahci-test.c
index f4945dc..8ebbd33 100644
--- a/tests/ahci-test.c
+++ b/tests/ahci-test.c
@@ -215,6 +215,7 @@ static AHCIQState *ahci_boot_and_enable(const char *cli, ...)
     va_list ap;
     uint16_t buff[256];
     uint8_t port;
+    uint8_t hello;
 
     if (cli) {
         va_start(ap, cli);
@@ -229,7 +230,12 @@ static AHCIQState *ahci_boot_and_enable(const char *cli, ...)
     /* Initialize test device */
     port = ahci_port_select(ahci);
     ahci_port_clear(ahci, port);
-    ahci_io(ahci, port, CMD_IDENTIFY, &buff, sizeof(buff), 0);
+    if (is_atapi(ahci, port)) {
+        hello = CMD_PACKET_ID;
+    } else {
+        hello = CMD_IDENTIFY;
+    }
+    ahci_io(ahci, port, hello, &buff, sizeof(buff), 0);
 
     return ahci;
 }
diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c
index 59bf893..81edf34 100644
--- a/tests/libqos/ahci.c
+++ b/tests/libqos/ahci.c
@@ -114,6 +114,11 @@ void ahci_free(AHCIQState *ahci, uint64_t addr)
     qfree(ahci->parent, addr);
 }
 
+bool is_atapi(AHCIQState *ahci, uint8_t port)
+{
+    return ahci_px_rreg(ahci, port, AHCI_PX_SIG) == AHCI_SIGNATURE_CDROM;
+}
+
 /**
  * Locate, verify, and return a handle to the AHCI device.
  */
diff --git a/tests/libqos/ahci.h b/tests/libqos/ahci.h
index 9ffd415..705fbd6 100644
--- a/tests/libqos/ahci.h
+++ b/tests/libqos/ahci.h
@@ -596,5 +596,6 @@ void ahci_command_adjust(AHCICommand *cmd, uint64_t lba_sect, uint64_t gbuffer,
 
 /* Command Misc */
 uint8_t ahci_command_slot(AHCICommand *cmd);
+bool is_atapi(AHCIQState *ahci, uint8_t port);
 
 #endif
-- 
2.4.3

  parent reply	other threads:[~2016-01-09  0:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-09  0:51 [Qemu-devel] [PULL 00/11] Ide patches John Snow
2016-01-09  0:51 ` [Qemu-devel] [PULL 01/11] macio: fix overflow in lba to offset conversion for ATAPI devices John Snow
2016-01-09  0:51 ` [Qemu-devel] [PULL 02/11] ide: ahci: reset ncq object to unused on error John Snow
2016-01-09  0:51 ` [Qemu-devel] [PULL 03/11] ahci-test: fix memory leak John Snow
2016-01-09  0:51 ` [Qemu-devel] [PULL 04/11] libqos/ahci: ATAPI support John Snow
2016-01-09  0:51 ` John Snow [this message]
2016-01-09  0:51 ` [Qemu-devel] [PULL 06/11] libqos/ahci: Switch to mutable properties John Snow
2016-01-09  0:51 ` [Qemu-devel] [PULL 07/11] libqos: allow zero-size allocations John Snow
2016-01-09  0:51 ` [Qemu-devel] [PULL 08/11] libqos/ahci: allow nondata commands for ahci_io variants John Snow
2016-01-09  0:51 ` [Qemu-devel] [PULL 09/11] libqos/ahci: add ahci_exec John Snow
2016-01-09  0:51 ` [Qemu-devel] [PULL 10/11] qtest/ahci: ATAPI data tests John Snow
2016-01-09  0:51 ` [Qemu-devel] [PULL 11/11] libqos/ahci: organize header John Snow
2016-01-11 11:18 ` [Qemu-devel] [PULL 00/11] Ide patches Peter Maydell
2016-01-11 17:18   ` John Snow
2016-01-11 17:36     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452300718-10660-6-git-send-email-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).