qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Janosch Frank <frankja@linux.vnet.ibm.com>
To: pbonzini@redhat.com
Cc: frankja@linux.vnet.ibm.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 12/34] scripts/kvm/kvm_stat: Moved DebugfsProvider
Date: Mon, 11 Jan 2016 16:17:42 +0100	[thread overview]
Message-ID: <1452525484-32309-13-git-send-email-frankja@linux.vnet.ibm.com> (raw)
In-Reply-To: <1452525484-32309-1-git-send-email-frankja@linux.vnet.ibm.com>

When it is next to the TracepointProvider less scrolling is needed to
change related, surrounding code.

Reviewed-by: Jason J. Herne <jjherne@linux.vnet.ibm.com>
Signed-off-by: Janosch Frank <frankja@linux.vnet.ibm.com>
---
 scripts/kvm/kvm_stat | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat
index 98e1ec7..b5422f8 100755
--- a/scripts/kvm/kvm_stat
+++ b/scripts/kvm/kvm_stat
@@ -23,18 +23,6 @@ import struct
 import re
 from collections import defaultdict
 
-class DebugfsProvider(object):
-    def __init__(self):
-        self._fields = walkdir(PATH_DEBUGFS_KVM)[2]
-    def fields(self):
-        return self._fields
-    def select(self, fields):
-        self._fields = fields
-    def read(self):
-        def val(key):
-            return int(file(PATH_DEBUGFS_KVM + '/' + key).read())
-        return dict([(key, val(key)) for key in self._fields])
-
 VMX_EXIT_REASONS = {
     'EXCEPTION_NMI':        0,
     'EXTERNAL_INTERRUPT':   1,
@@ -441,6 +429,18 @@ class TracepointProvider(object):
                 ret[name] += val
         return ret
 
+class DebugfsProvider(object):
+    def __init__(self):
+        self._fields = walkdir(PATH_DEBUGFS_KVM)[2]
+    def fields(self):
+        return self._fields
+    def select(self, fields):
+        self._fields = fields
+    def read(self):
+        def val(key):
+            return int(file(PATH_DEBUGFS_KVM + '/' + key).read())
+        return dict([(key, val(key)) for key in self._fields])
+
 class Stats:
     def __init__(self, providers, fields=None):
         self.providers = providers
-- 
2.3.0

  parent reply	other threads:[~2016-01-11 15:19 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-11 15:17 [Qemu-devel] [PATCH v2 00/34] kvm_stat: Cleanup and fixup Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 01/34] scripts/kvm/kvm_stat: Cleanup of multiple imports Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 02/34] scripts/kvm/kvm_stat: Replaced os.listdir with os.walk Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 03/34] scripts/kvm/kvm_stat: Make constants uppercase Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 04/34] scripts/kvm/kvm_stat: Removed unneeded PERF constants Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 05/34] scripts/kvm/kvm_stat: Mark globals in functions Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 06/34] scripts/kvm/kvm_stat: Invert dictionaries Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 07/34] scripts/kvm/kvm_stat: Cleanup of path variables Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 08/34] scripts/kvm/kvm_stat: Improve debugfs access checking Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 09/34] scripts/kvm/kvm_stat: Introduce main function Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 10/34] scripts/kvm/kvm_stat: Fix spaces around keyword assignments Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 11/34] scripts/kvm/kvm_stat: Rename variables that redefine globals Janosch Frank
2016-01-11 15:17 ` Janosch Frank [this message]
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 13/34] scripts/kvm/kvm_stat: Fixup syscall error reporting Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 14/34] scripts/kvm/kvm_stat: Set sensible no. files rlimit Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 15/34] scripts/kvm/kvm_stat: Cleanup of platform detection Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 16/34] scripts/kvm/kvm_stat: Make cpu detection a function Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 17/34] scripts/kvm/kvm_stat: Rename _perf_event_open Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 18/34] scripts/kvm/kvm_stat: Introduce properties for providers Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 19/34] scripts/kvm/kvm_stat: Cleanup of TracepointProvider Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 20/34] scripts/kvm/kvm_stat: Cleanup cpu list retrieval Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 21/34] scripts/kvm/kvm_stat: Encapsulate filters variable Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 22/34] scripts/kvm/kvm_stat: Cleanup of Stats class Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 23/34] scripts/kvm/kvm_stat: Cleanup of Groups class Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 24/34] scripts/kvm/kvm_stat: Cleanup of Event class Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 25/34] scripts/kvm/kvm_stat: Group arch specific data Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 26/34] scripts/kvm/kvm_stat: Remove unneeded X86_EXIT_REASONS Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 27/34] scripts/kvm/kvm_stat: Make tui function a class Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 28/34] scripts/kvm/kvm_stat: Fix output formatting Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 29/34] scripts/kvm/kvm_stat: Cleanup and pre-init perf_event_attr Janosch Frank
2016-01-11 15:18 ` [Qemu-devel] [PATCH v2 30/34] scripts/kvm/kvm_stat: Read event values as u64 Janosch Frank
2016-01-11 15:18 ` [Qemu-devel] [PATCH v2 31/34] scripts/kvm/kvm_stat: Fix rlimit for unprivileged users Janosch Frank
2016-01-20 11:03   ` Paolo Bonzini
2016-01-11 15:18 ` [Qemu-devel] [PATCH v2 32/34] scripts/kvm/kvm_stat: Fixup filtering Janosch Frank
2016-01-11 15:18 ` [Qemu-devel] [PATCH v2 33/34] scripts/kvm/kvm_stat: Add interactive filtering Janosch Frank
2016-01-11 15:18 ` [Qemu-devel] [PATCH v2 34/34] scripts/kvm/kvm_stat: Add optparse description Janosch Frank
2016-01-20 11:08 ` [Qemu-devel] [PATCH v2 00/34] kvm_stat: Cleanup and fixup Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452525484-32309-13-git-send-email-frankja@linux.vnet.ibm.com \
    --to=frankja@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).