From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39136)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1aIzvI-0006Oc-LN
	for qemu-devel@nongnu.org; Tue, 12 Jan 2016 09:27:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1aIzvD-0006Ur-I1
	for qemu-devel@nongnu.org; Tue, 12 Jan 2016 09:27:48 -0500
Received: from mx1.redhat.com ([209.132.183.28]:34373)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1aIzvD-0006Uh-Ck
	for qemu-devel@nongnu.org; Tue, 12 Jan 2016 09:27:43 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (Postfix) with ESMTPS id 150B48E241
	for <qemu-devel@nongnu.org>; Tue, 12 Jan 2016 14:27:43 +0000 (UTC)
Message-ID: <1452608861.29014.28.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 12 Jan 2016 15:27:41 +0100
In-Reply-To: <1452607738-1521-1-git-send-email-cfergeau@redhat.com>
References: <1452607738-1521-1-git-send-email-cfergeau@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Fix corner-case when using VNC+SASL+SPICE
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christophe Fergeau <cfergeau@redhat.com>
Cc: qemu-devel@nongnu.org

On Di, 2016-01-12 at 15:08 +0100, Christophe Fergeau wrote:
> Similarly to the commit 764eb39d1b6 fixing VNC+SASL+QXL, when starting
> QEMU with SPICE but no SASL, and at the same time VNC with SASL, then
> spice_server_init() will get called without a previous call to
> spice_server_set_sasl_appname(), which will cause cyrus-sasl to
> try to use /etc/sasl2/spice.conf (spice-server uses "spice" as its
> default appname) rather than the expected /etc/sasl2/qemu.conf.
>=20
> This commit unconditionnally calls spice_server_set_sasl_appname()
> before calling spice_server_init() in order to use the correct appname
> even if SPICE without SASL was requested on qemu command line.

Added to patch queue.

thanks,
  Gerd