From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJK8N-0004JG-KN for qemu-devel@nongnu.org; Wed, 13 Jan 2016 07:02:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJK8J-000593-37 for qemu-devel@nongnu.org; Wed, 13 Jan 2016 07:02:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51814) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJK8I-000586-U9 for qemu-devel@nongnu.org; Wed, 13 Jan 2016 07:02:35 -0500 From: Gerd Hoffmann Date: Wed, 13 Jan 2016 13:02:25 +0100 Message-Id: <1452686548-6291-4-git-send-email-kraxel@redhat.com> In-Reply-To: <1452686548-6291-1-git-send-email-kraxel@redhat.com> References: <1452686548-6291-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH 3/6] virtio-gpu: fix memory leak in error path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann , "Michael S. Tsirkin" Found by Coverity Scan, buf not freed on error. Signed-off-by: Gerd Hoffmann --- hw/display/virtio-gpu-3d.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c index 28dccfd..d2af327 100644 --- a/hw/display/virtio-gpu-3d.c +++ b/hw/display/virtio-gpu-3d.c @@ -197,7 +197,7 @@ static void virgl_cmd_submit_3d(VirtIOGPU *g, qemu_log_mask(LOG_GUEST_ERROR, "%s: size mismatch (%zd/%d)", __func__, s, cs.size); cmd->error = VIRTIO_GPU_RESP_ERR_INVALID_PARAMETER; - return; + goto out; } if (virtio_gpu_stats_enabled(g->conf)) { @@ -207,6 +207,7 @@ static void virgl_cmd_submit_3d(VirtIOGPU *g, virgl_renderer_submit_cmd(buf, cs.hdr.ctx_id, cs.size / 4); +out: g_free(buf); } -- 1.8.3.1