From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36973) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJjHB-0003Pg-Rt for qemu-devel@nongnu.org; Thu, 14 Jan 2016 09:53:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJjHA-0006SL-VN for qemu-devel@nongnu.org; Thu, 14 Jan 2016 09:53:25 -0500 From: Peter Maydell Date: Thu, 14 Jan 2016 14:53:22 +0000 Message-Id: <1452783202-576-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH] disas/libvixl: Really suppress gcc 4.6.3 sign-compare warnings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Franz-Josef Haider , qemu-arm@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , patches@linaro.org Commit 8acc216b956 attempted to silence some sign-compare warnings in libvixl by adding -Wno-sign-compare to the CFLAGS for the relevant objects. Unfortunately it was ineffective because it was placed before $(QEMU_CFLAGS), so the -Wall in the general flags overrode -Wno-sign-compare rather than vice-versa. Reorder the flags so the warning suppression works. Thanks to Franz-Josef Haider for pointing out what was wrong with the original patch. Signed-off-by: Peter Maydell --- Alex, is there a way to test this patch against Travis before we commit it to master? disas/libvixl/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/disas/libvixl/Makefile.objs b/disas/libvixl/Makefile.objs index d1e801a..bbe7695 100644 --- a/disas/libvixl/Makefile.objs +++ b/disas/libvixl/Makefile.objs @@ -6,6 +6,6 @@ libvixl_OBJS = vixl/utils.o \ # The -Wno-sign-compare is needed only for gcc 4.6, which complains about # some signed-unsigned equality comparisons which later gcc versions do not. -$(addprefix $(obj)/,$(libvixl_OBJS)): QEMU_CFLAGS := -I$(SRC_PATH)/disas/libvixl -Wno-sign-compare $(QEMU_CFLAGS) +$(addprefix $(obj)/,$(libvixl_OBJS)): QEMU_CFLAGS := -I$(SRC_PATH)/disas/libvixl $(QEMU_CFLAGS) -Wno-sign-compare common-obj-$(CONFIG_ARM_A64_DIS) += $(libvixl_OBJS) -- 1.9.1