[Qemu-devel] [PATCH] docs/qapi-code-gen.txt: Fix simple union introspection example

[Qemu-devel] [PATCH] docs/qapi-code-gen.txt: Fix simple union introspection example

[Markus Armbruster]

The implicit tag member is named "type", not "kind".  Screwed up in
commit 39a1815.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 docs/qapi-code-gen.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/qapi-code-gen.txt b/docs/qapi-code-gen.txt
index 128f074..b11fa68 100644
--- a/docs/qapi-code-gen.txt
+++ b/docs/qapi-code-gen.txt
@@ -655,7 +655,7 @@ Union types
 
     { "name": "BlockdevOptions", "meta-type": "object",
       "members": [
-          { "name": "kind", "type": "BlockdevOptionsKind" } ],
+          { "name": "type", "type": "BlockdevOptionsKind" } ],
       "tag": "type",
       "variants": [
           { "case": "file", "type": ":obj-FileOptions-wrapper" },
-- 
2.4.3

Re: [Qemu-devel] [PATCH] docs/qapi-code-gen.txt: Fix simple union introspection example

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 892 bytes --]

On 01/14/2016 08:13 AM, Markus Armbruster wrote:
> The implicit tag member is named "type", not "kind".  Screwed up in
> commit 39a1815.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  docs/qapi-code-gen.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

However, there's other errors in the documentation (we haven't kept it
up-to-date with recent churn in the generator), so maybe it's better to
fix all of them at once.  See my Subset E series:
https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03863.html
https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg00410.html

(I'll probably have to send a v9 of the series, but wanted to see if you
had any comments on v8 first)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

Re: [Qemu-devel] [PATCH] docs/qapi-code-gen.txt: Fix simple union introspection example

[Markus Armbruster]

Eric Blake <eblake@redhat.com> writes:

> On 01/14/2016 08:13 AM, Markus Armbruster wrote:
>> The implicit tag member is named "type", not "kind".  Screwed up in
>> commit 39a1815.
>> 
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  docs/qapi-code-gen.txt | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> However, there's other errors in the documentation (we haven't kept it
> up-to-date with recent churn in the generator), so maybe it's better to
> fix all of them at once.  See my Subset E series:
> https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03863.html
> https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg00410.html

Feel free to fold my patch into yours.

> (I'll probably have to send a v9 of the series, but wanted to see if you
> had any comments on v8 first)

In my review queue.