From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK67d-00059Z-E4 for qemu-devel@nongnu.org; Fri, 15 Jan 2016 10:17:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aK67c-0007BK-M4 for qemu-devel@nongnu.org; Fri, 15 Jan 2016 10:17:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36006) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK67c-0007B2-H3 for qemu-devel@nongnu.org; Fri, 15 Jan 2016 10:17:04 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 3ECEB49DCC for ; Fri, 15 Jan 2016 15:17:04 +0000 (UTC) From: Paolo Bonzini Date: Fri, 15 Jan 2016 16:17:01 +0100 Message-Id: <1452871021-32405-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH] qemu-char: do not leak QemuMutex when freeing a character device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org The leak is only apparent on Win32. On POSIX platforms destroying a mutex is not necessary. Reported-by: Eric Blake Signed-off-by: Paolo Bonzini --- qemu-char.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qemu-char.c b/qemu-char.c index 02b0318..c7b8699 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -3967,6 +3967,7 @@ static void qemu_chr_free_common(CharDriverState *chr) if (chr->logfd != -1) { close(chr->logfd); } + qemu_mutex_destroy(&chr->chr_write_lock); g_free(chr); } -- 2.5.0