From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51081) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLBiQ-0003VO-2m for qemu-devel@nongnu.org; Mon, 18 Jan 2016 10:27:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLBiL-0004M3-T4 for qemu-devel@nongnu.org; Mon, 18 Jan 2016 10:27:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59356) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLBiL-0004Lb-Nk for qemu-devel@nongnu.org; Mon, 18 Jan 2016 10:27:29 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id D7271219D for ; Mon, 18 Jan 2016 15:27:28 +0000 (UTC) From: Marcel Apfelbaum Date: Mon, 18 Jan 2016 17:27:26 +0200 Message-Id: <1453130846-14064-1-git-send-email-marcel@redhat.com> Subject: [Qemu-devel] [PATCH] hw/pci: ensure that only PCI/PCIe bridges can be attached to pxb/pxb-pcie devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: marcel@redhat.com, lersek@redhat.com, mst@redhat.com PCI devices can't be plugged directly into PCI extra root bridges because their resources can't be computed by firmware before the ACPI tables are loaded. Signed-off-by: Marcel Apfelbaum --- Hi, This patch follows the discussion: https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg01484.html Thanks, Marcel hw/pci/pci.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 168b9cc..584f504 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -850,6 +850,13 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus, DeviceState *dev = DEVICE(pci_dev); pci_dev->bus = bus; + /* Only pci bridges can be attached to extra PCI root buses */ + if (pci_bus_is_root(bus) && bus->parent_dev && !pc->is_bridge) { + error_setg(errp, + "PCI: Only PCI/PCIe bridges can be plugged into %s", + bus->parent_dev->name); + return NULL; + } if (devfn < 0) { for(devfn = bus->devfn_min ; devfn < ARRAY_SIZE(bus->devices); -- 2.4.3