From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMako-0000v5-Lw for qemu-devel@nongnu.org; Fri, 22 Jan 2016 07:23:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMakk-0001cb-Gi for qemu-devel@nongnu.org; Fri, 22 Jan 2016 07:23:50 -0500 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:33289) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMakk-0001c5-6Q for qemu-devel@nongnu.org; Fri, 22 Jan 2016 07:23:46 -0500 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 22 Jan 2016 12:23:45 -0000 From: Cornelia Huck Date: Fri, 22 Jan 2016 13:23:31 +0100 Message-Id: <1453465413-12846-9-git-send-email-cornelia.huck@de.ibm.com> In-Reply-To: <1453465413-12846-1-git-send-email-cornelia.huck@de.ibm.com> References: <1453465413-12846-1-git-send-email-cornelia.huck@de.ibm.com> Subject: [Qemu-devel] [PATCH 08/10] s390x/css: fix control flags during csch List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Halil Pasic , agraf@suse.de, qemu-stable@nongnu.org, borntraeger@de.ibm.com, jfrei@linux.vnet.ibm.com, Cornelia Huck From: Halil Pasic >>From the beginning, css support contained an error in csch handling: instead of setting the clear bit in the function control bits twice, we need to set the clear pending bit in the activity control bits. Let's fix this. Cc: qemu-stable@nongnu.org Reviewed-by: Cornelia Huck Signed-off-by: Halil Pasic Signed-off-by: Cornelia Huck --- hw/s390x/css.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/s390x/css.c b/hw/s390x/css.c index 533357a..e83bf60 100644 --- a/hw/s390x/css.c +++ b/hw/s390x/css.c @@ -702,7 +702,7 @@ int css_do_csch(SubchDev *sch) /* Trigger the clear function. */ s->ctrl &= ~(SCSW_CTRL_MASK_FCTL | SCSW_CTRL_MASK_ACTL); - s->ctrl |= SCSW_FCTL_CLEAR_FUNC | SCSW_FCTL_CLEAR_FUNC; + s->ctrl |= SCSW_FCTL_CLEAR_FUNC | SCSW_ACTL_CLEAR_PEND; do_subchannel_work(sch, NULL); ret = 0; -- 2.7.0