From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42224) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aN4zc-00067t-NI for qemu-devel@nongnu.org; Sat, 23 Jan 2016 15:41:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aN4za-0005SF-BV for qemu-devel@nongnu.org; Sat, 23 Jan 2016 15:41:08 -0500 From: =?UTF-8?q?Herv=C3=A9=20Poussineau?= Date: Sat, 23 Jan 2016 21:39:59 +0100 Message-Id: <1453581610-23179-3-git-send-email-hpoussin@reactos.org> In-Reply-To: <1453581610-23179-1-git-send-email-hpoussin@reactos.org> References: <1453581610-23179-1-git-send-email-hpoussin@reactos.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH 02/13] cuda: reject unknown commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Mark Cave-Ayland , Alexander Graf , Alyssa Milburn , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , qemu-ppc@nongnu.org, David Gibson Signed-off-by: Herv=C3=A9 Poussineau --- hw/misc/macio/cuda.c | 25 ++++++++++++++++--------- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/hw/misc/macio/cuda.c b/hw/misc/macio/cuda.c index 69f69c2..f27dd19 100644 --- a/hw/misc/macio/cuda.c +++ b/hw/misc/macio/cuda.c @@ -589,15 +589,15 @@ static void cuda_receive_packet(CUDAState *s, } } cuda_send_packet_to_host(s, obuf, 3); - break; + return; case CUDA_GET_6805_ADDR: cuda_send_packet_to_host(s, obuf, 3); - break; + return; case CUDA_SET_TIME: ti =3D (((uint32_t)data[1]) << 24) + (((uint32_t)data[2]) << 16)= + (((uint32_t)data[3]) << 8) + data[4]; s->tick_offset =3D ti - (qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) /= get_ticks_per_sec()); cuda_send_packet_to_host(s, obuf, 3); - break; + return; case CUDA_GET_TIME: ti =3D s->tick_offset + (qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) /= get_ticks_per_sec()); obuf[3] =3D ti >> 24; @@ -605,28 +605,28 @@ static void cuda_receive_packet(CUDAState *s, obuf[5] =3D ti >> 8; obuf[6] =3D ti; cuda_send_packet_to_host(s, obuf, 7); - break; + return; case CUDA_FILE_SERVER_FLAG: case CUDA_SET_DEVICE_LIST: case CUDA_SET_AUTO_RATE: case CUDA_SET_POWER_MESSAGES: cuda_send_packet_to_host(s, obuf, 3); - break; + return; case CUDA_POWERDOWN: cuda_send_packet_to_host(s, obuf, 3); qemu_system_shutdown_request(); - break; + return; case CUDA_RESET_SYSTEM: cuda_send_packet_to_host(s, obuf, 3); qemu_system_reset_request(); - break; + return; case CUDA_COMBINED_FORMAT_IIC: obuf[0] =3D ERROR_PACKET; obuf[1] =3D 0x5; obuf[2] =3D CUDA_PACKET; obuf[3] =3D data[0]; cuda_send_packet_to_host(s, obuf, 4); - break; + return; case CUDA_GET_SET_IIC: if (len =3D=3D 4) { cuda_send_packet_to_host(s, obuf, 3); @@ -637,10 +637,17 @@ static void cuda_receive_packet(CUDAState *s, obuf[3] =3D data[0]; cuda_send_packet_to_host(s, obuf, 4); } - break; + return; default: break; } + + qemu_log_mask(LOG_GUEST_ERROR, "CUDA: unknown command 0x%02x\n", dat= a[0]); + obuf[0] =3D ERROR_PACKET; + obuf[1] =3D 0x2; /* unknown command */ + obuf[2] =3D CUDA_PACKET; + obuf[3] =3D data[0]; + cuda_send_packet_to_host(s, obuf, 4); } =20 static void cuda_receive_packet_from_host(CUDAState *s, --=20 2.1.4