From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, mreitz@redhat.com,
Stefan Hajnoczi <stefanha@redhat.com>,
pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH v8 12/15] block: Use returned *file in bdrv_co_get_block_status
Date: Mon, 25 Jan 2016 10:44:44 +0800 [thread overview]
Message-ID: <1453689887-2567-13-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1453689887-2567-1-git-send-email-famz@redhat.com>
Now that all drivers return the right "file" pointer, we can use it.
Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
block/io.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/io.c b/block/io.c
index 0836991..d704d32 100644
--- a/block/io.c
+++ b/block/io.c
@@ -1552,13 +1552,13 @@ static int64_t coroutine_fn bdrv_co_get_block_status(BlockDriverState *bs,
}
}
- if (bs->file &&
+ if (*file && *file != bs &&
(ret & BDRV_BLOCK_DATA) && !(ret & BDRV_BLOCK_ZERO) &&
(ret & BDRV_BLOCK_OFFSET_VALID)) {
BlockDriverState *file2;
int file_pnum;
- ret2 = bdrv_co_get_block_status(bs->file->bs, ret >> BDRV_SECTOR_BITS,
+ ret2 = bdrv_co_get_block_status(*file, ret >> BDRV_SECTOR_BITS,
*pnum, &file_pnum, &file2);
if (ret2 >= 0) {
/* Ignore errors. This is just providing extra information, it
--
2.4.3
next prev parent reply other threads:[~2016-01-25 2:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 2:44 [Qemu-devel] [PATCH v8 00/15] qemu-img map: Allow driver to return file of the allocated block Fam Zheng
2016-01-25 2:44 ` [Qemu-devel] [PATCH v8 01/15] block: Add "file" output parameter to block status query functions Fam Zheng
2016-01-25 13:04 ` Kevin Wolf
2016-01-26 3:27 ` Fam Zheng
2016-01-26 3:36 ` Fam Zheng
2016-01-25 2:44 ` [Qemu-devel] [PATCH v8 02/15] qcow: Assign bs->file->bs to file in qcow_co_get_block_status Fam Zheng
2016-01-25 2:44 ` [Qemu-devel] [PATCH v8 03/15] qcow2: Assign bs->file->bs to file in qcow2_co_get_block_status Fam Zheng
2016-01-25 2:44 ` [Qemu-devel] [PATCH v8 04/15] raw: Assign bs to file in raw_co_get_block_status Fam Zheng
2016-01-25 13:17 ` Kevin Wolf
2016-01-26 3:37 ` Fam Zheng
2016-01-25 2:44 ` [Qemu-devel] [PATCH v8 05/15] iscsi: Assign bs to file in iscsi_co_get_block_status Fam Zheng
2016-01-25 2:44 ` [Qemu-devel] [PATCH v8 06/15] parallels: Assign bs->file->bs to file in parallels_co_get_block_status Fam Zheng
2016-01-25 2:44 ` [Qemu-devel] [PATCH v8 07/15] qed: Assign bs->file->bs to file in bdrv_qed_co_get_block_status Fam Zheng
2016-01-25 2:44 ` [Qemu-devel] [PATCH v8 08/15] sheepdog: Assign bs to file in sd_co_get_block_status Fam Zheng
2016-01-25 2:44 ` [Qemu-devel] [PATCH v8 09/15] vdi: Assign bs->file->bs to file in vdi_co_get_block_status Fam Zheng
2016-01-25 2:44 ` [Qemu-devel] [PATCH v8 10/15] vpc: Assign bs->file->bs to file in vpc_co_get_block_status Fam Zheng
2016-01-25 2:44 ` [Qemu-devel] [PATCH v8 11/15] vmdk: Return extent's file in bdrv_get_block_status Fam Zheng
2016-01-25 13:28 ` Kevin Wolf
2016-01-26 3:44 ` Fam Zheng
2016-01-25 2:44 ` Fam Zheng [this message]
2016-01-25 2:44 ` [Qemu-devel] [PATCH v8 13/15] qemu-img: In "map", use the returned "file" from bdrv_get_block_status Fam Zheng
2016-01-25 2:44 ` [Qemu-devel] [PATCH v8 14/15] qemu-img: Make MapEntry a QAPI struct Fam Zheng
2016-01-25 2:44 ` [Qemu-devel] [PATCH v8 15/15] iotests: Add "qemu-img map" test for VMDK extents Fam Zheng
2016-01-25 14:11 ` Max Reitz
2016-01-25 14:17 ` Max Reitz
2016-01-26 3:45 ` Fam Zheng
2016-01-25 13:37 ` [Qemu-devel] [PATCH v8 00/15] qemu-img map: Allow driver to return file of the allocated block Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453689887-2567-13-git-send-email-famz@redhat.com \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).