From: Gerd Hoffmann <kraxel@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] gtk: use qemu_chr_alloc() to allocate CharDriverState
Date: Tue, 26 Jan 2016 12:39:06 +0100 [thread overview]
Message-ID: <1453808346.24277.24.camel@redhat.com> (raw)
In-Reply-To: <1453377386-10190-1-git-send-email-berrange@redhat.com>
On Do, 2016-01-21 at 11:56 +0000, Daniel P. Berrange wrote:
> The gd_vc_handler() callback is using g_malloc0() to
> allocate the CharDriverState struct. As a result the
> logfd field is getting initialized to 0, instead of
> -1 when no logfile is requested.
added to patch queue.
thanks,
Gerd
prev parent reply other threads:[~2016-01-26 11:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 11:56 [Qemu-devel] [PATCH] gtk: use qemu_chr_alloc() to allocate CharDriverState Daniel P. Berrange
2016-01-21 16:42 ` Eric Blake
2016-01-21 17:55 ` Peter Maydell
2016-01-21 18:38 ` Hervé Poussineau
2016-01-26 11:39 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453808346.24277.24.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=berrange@redhat.com \
--cc=hpoussin@reactos.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).