From: "Hervé Poussineau" <hpoussin@reactos.org>
To: qemu-devel@nongnu.org
Cc: "Hervé Poussineau" <hpoussin@reactos.org>,
"John Snow" <jsnow@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH v3 16/19] cs4231a: use IsaDma interface instead of global DMA_* functions
Date: Tue, 26 Jan 2016 22:32:21 +0100 [thread overview]
Message-ID: <1453843944-26833-17-git-send-email-hpoussin@reactos.org> (raw)
In-Reply-To: <1453843944-26833-1-git-send-email-hpoussin@reactos.org>
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
hw/audio/cs4231a.c | 23 +++++++++++++++--------
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/hw/audio/cs4231a.c b/hw/audio/cs4231a.c
index f96f561..d84f83f 100644
--- a/hw/audio/cs4231a.c
+++ b/hw/audio/cs4231a.c
@@ -69,6 +69,7 @@ typedef struct CSState {
uint32_t irq;
uint32_t dma;
uint32_t port;
+ IsaDma *isa_dma;
int shift;
int dma_running;
int audio_free;
@@ -264,6 +265,7 @@ static void cs_reset_voices (CSState *s, uint32_t val)
{
int xtal;
struct audsettings as;
+ IsaDmaClass *k = ISADMA_GET_CLASS(s->isa_dma);
#ifdef DEBUG_XLAW
if (val == 0 || val == 32)
@@ -327,7 +329,7 @@ static void cs_reset_voices (CSState *s, uint32_t val)
if (s->dregs[Interface_Configuration] & PEN) {
if (!s->dma_running) {
- DMA_hold_DREQ (s->dma);
+ k->hold_DREQ(s->isa_dma, s->dma);
AUD_set_active_out (s->voice, 1);
s->transferred = 0;
}
@@ -335,7 +337,7 @@ static void cs_reset_voices (CSState *s, uint32_t val)
}
else {
if (s->dma_running) {
- DMA_release_DREQ (s->dma);
+ k->release_DREQ(s->isa_dma, s->dma);
AUD_set_active_out (s->voice, 0);
}
s->dma_running = 0;
@@ -344,7 +346,7 @@ static void cs_reset_voices (CSState *s, uint32_t val)
error:
if (s->dma_running) {
- DMA_release_DREQ (s->dma);
+ k->release_DREQ(s->isa_dma, s->dma);
AUD_set_active_out (s->voice, 0);
}
}
@@ -452,7 +454,8 @@ static void cs_write (void *opaque, hwaddr addr,
}
else {
if (s->dma_running) {
- DMA_release_DREQ (s->dma);
+ IsaDmaClass *k = ISADMA_GET_CLASS(s->isa_dma);
+ k->release_DREQ(s->isa_dma, s->dma);
AUD_set_active_out (s->voice, 0);
s->dma_running = 0;
}
@@ -517,6 +520,7 @@ static int cs_write_audio (CSState *s, int nchan, int dma_pos,
{
int temp, net;
uint8_t tmpbuf[4096];
+ IsaDmaClass *k = ISADMA_GET_CLASS(s->isa_dma);
temp = len;
net = 0;
@@ -531,7 +535,7 @@ static int cs_write_audio (CSState *s, int nchan, int dma_pos,
to_copy = sizeof (tmpbuf);
}
- copied = DMA_read_memory (nchan, tmpbuf, dma_pos, to_copy);
+ copied = k->read_memory(s->isa_dma, nchan, tmpbuf, dma_pos, to_copy);
if (s->tab) {
int i;
int16_t linbuf[4096];
@@ -599,7 +603,8 @@ static int cs4231a_pre_load (void *opaque)
CSState *s = opaque;
if (s->dma_running) {
- DMA_release_DREQ (s->dma);
+ IsaDmaClass *k = ISADMA_GET_CLASS(s->isa_dma);
+ k->release_DREQ(s->isa_dma, s->dma);
AUD_set_active_out (s->voice, 0);
}
s->dma_running = 0;
@@ -655,13 +660,15 @@ static void cs4231a_realizefn (DeviceState *dev, Error **errp)
{
ISADevice *d = ISA_DEVICE (dev);
CSState *s = CS4231A (dev);
+ IsaDmaClass *k;
isa_init_irq (d, &s->pic, s->irq);
+ s->isa_dma = isa_get_dma(isa_bus_from_device(d), s->dma);
+ k = ISADMA_GET_CLASS(s->isa_dma);
+ k->register_channel(s->isa_dma, s->dma, cs_dma_read, s);
isa_register_ioport (d, &s->ioports, s->port);
- DMA_register_channel (s->dma, cs_dma_read, s);
-
AUD_register_card ("cs4231a", &s->card);
}
--
2.1.4
next prev parent reply other threads:[~2016-01-26 21:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 21:32 [Qemu-devel] [PATCH v3 00/19] ISA DMA controllers cleanup (i8257, i82374) Hervé Poussineau
2016-01-26 21:32 ` [Qemu-devel] [PATCH v3 01/19] i82374: device only existed as ISA device, so simplify device Hervé Poussineau
2016-01-26 21:32 ` [Qemu-devel] [PATCH v3 02/19] i8257: pass ISA bus to DMA_init() function Hervé Poussineau
2016-01-26 21:32 ` [Qemu-devel] [PATCH v3 03/19] i8257: rename struct dma_cont to I8257State Hervé Poussineau
2016-01-26 21:32 ` [Qemu-devel] [PATCH v3 04/19] i8257: rename struct dma_regs to I8257Regs Hervé Poussineau
2016-01-26 21:32 ` [Qemu-devel] [PATCH v3 05/19] i8257: rename functions to start with i8257_ prefix Hervé Poussineau
2016-01-26 21:32 ` [Qemu-devel] [PATCH v3 06/19] i8257: make the DMA running method per controller Hervé Poussineau
2016-01-26 21:32 ` [Qemu-devel] [PATCH v3 07/19] i8257: add missing const Hervé Poussineau
2016-01-26 21:32 ` [Qemu-devel] [PATCH v3 08/19] i8257: QOM'ify Hervé Poussineau
2016-01-26 21:32 ` [Qemu-devel] [PATCH v3 09/19] i8257: move state definition to new independent header Hervé Poussineau
2016-01-26 21:32 ` [Qemu-devel] [PATCH v3 10/19] isa: add an ISA DMA interface, and store it within the ISA bus Hervé Poussineau
2016-01-26 21:32 ` [Qemu-devel] [PATCH v3 11/19] i8257: implement the IsaDma interface Hervé Poussineau
2016-01-26 21:32 ` [Qemu-devel] [PATCH v3 12/19] magnum: disable floppy DMA for now Hervé Poussineau
2016-01-26 21:32 ` [Qemu-devel] [PATCH v3 13/19] sparc: disable floppy DMA Hervé Poussineau
2016-01-26 21:32 ` [Qemu-devel] [PATCH v3 14/19] sparc64: " Hervé Poussineau
2016-01-26 21:32 ` [Qemu-devel] [PATCH v3 15/19] fdc: use IsaDma interface instead of global DMA_* functions Hervé Poussineau
2016-01-26 21:32 ` Hervé Poussineau [this message]
2016-01-26 21:32 ` [Qemu-devel] [PATCH v3 17/19] gus: " Hervé Poussineau
2016-01-26 21:32 ` [Qemu-devel] [PATCH v3 18/19] sb16: " Hervé Poussineau
2016-01-26 21:32 ` [Qemu-devel] [PATCH v3 19/19] dma: remove now useless " Hervé Poussineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453843944-26833-17-git-send-email-hpoussin@reactos.org \
--to=hpoussin@reactos.org \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).