From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOJOM-0007eZ-1L for qemu-devel@nongnu.org; Wed, 27 Jan 2016 01:15:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aOJOI-0004jn-S1 for qemu-devel@nongnu.org; Wed, 27 Jan 2016 01:15:45 -0500 Received: from mga02.intel.com ([134.134.136.20]:26933) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOJOI-0004hW-L5 for qemu-devel@nongnu.org; Wed, 27 Jan 2016 01:15:42 -0500 From: Liang Li Date: Wed, 27 Jan 2016 14:11:05 +0800 Message-Id: <1453875065-24326-1-git-send-email-liang.z.li@intel.com> Subject: [Qemu-devel] [PATCH] migration: remove useless code. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: amit.shah@redhat.com, Liang Li , dgilbert@redhat.com, quintela@redhat.com Since 's->state' will be set in migrate_init(), there is no need to set it before calling migrate_init(). The code and the related comments can be removed. Signed-off-by: Liang Li --- migration/migration.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index aaca451..ae38242 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -1006,12 +1006,6 @@ void qmp_migrate(const char *uri, bool has_blk, bool blk, return; } - /* We are starting a new migration, so we want to start in a clean - state. This change is only needed if previous migration - failed/was cancelled. We don't use migrate_set_state() because - we are setting the initial state, not changing it. */ - s->state = MIGRATION_STATUS_NONE; - s = migrate_init(¶ms); if (strstart(uri, "tcp:", &p)) { -- 1.9.1