From: Gerd Hoffmann <kraxel@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: lprosek@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] virtio-pci: call pci reset variant when guest clears status.
Date: Thu, 28 Jan 2016 10:33:25 +0100 [thread overview]
Message-ID: <1453973605.30975.6.camel@redhat.com> (raw)
In-Reply-To: <20160127174949-mutt-send-email-mst@redhat.com>
> > if (vdev->status == 0) {
> > - virtio_reset(vdev);
> > - msix_unuse_all_vectors(&proxy->pci_dev);
> > + virtio_pci_reset(DEVICE(proxy));
> > }
> >
> > /* Linux before 2.6.34 drives the device without enabling
>
> Aren't there two call sites in virtio_ioport_write?
/me was specifically fixing clear-status code paths mentioned in the
commit message.
Yes, there is another one, not fully sure what is supposed to happen
there.
cheers,
Gerd
next prev parent reply other threads:[~2016-01-28 9:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 14:09 [Qemu-devel] [PATCH v2] virtio-pci: call pci reset variant when guest clears status Gerd Hoffmann
2016-01-27 15:50 ` Michael S. Tsirkin
2016-01-28 9:33 ` Gerd Hoffmann [this message]
2016-01-28 11:26 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453973605.30975.6.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=lprosek@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).