From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOixH-0005uR-R5 for qemu-devel@nongnu.org; Thu, 28 Jan 2016 04:33:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aOixE-0006oi-LI for qemu-devel@nongnu.org; Thu, 28 Jan 2016 04:33:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47766) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOixE-0006oS-GB for qemu-devel@nongnu.org; Thu, 28 Jan 2016 04:33:28 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 9175CC0A9CEC for ; Thu, 28 Jan 2016 09:33:27 +0000 (UTC) Message-ID: <1453973605.30975.6.camel@redhat.com> From: Gerd Hoffmann Date: Thu, 28 Jan 2016 10:33:25 +0100 In-Reply-To: <20160127174949-mutt-send-email-mst@redhat.com> References: <1453903798-28857-1-git-send-email-kraxel@redhat.com> <20160127174949-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v2] virtio-pci: call pci reset variant when guest clears status. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: lprosek@redhat.com, qemu-devel@nongnu.org > > if (vdev->status =3D=3D 0) { > > - virtio_reset(vdev); > > - msix_unuse_all_vectors(&proxy->pci_dev); > > + virtio_pci_reset(DEVICE(proxy)); > > } > > =20 > > /* Linux before 2.6.34 drives the device without enabling >=20 > Aren't there two call sites in virtio_ioport_write? /me was specifically fixing clear-status code paths mentioned in the commit message. Yes, there is another one, not fully sure what is supposed to happen there. cheers, Gerd