From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: peter.maydell@linaro.org
Cc: agraf@suse.de, Halil Pasic <pasic@linux.vnet.ibm.com>,
qemu-stable@nongnu.org, qemu-devel@nongnu.org,
borntraeger@de.ibm.com, jfrei@linux.vnet.ibm.com,
Cornelia Huck <cornelia.huck@de.ibm.com>
Subject: [Qemu-devel] [PULL 08/10] s390x/css: fix control flags during csch
Date: Thu, 28 Jan 2016 12:09:09 +0100 [thread overview]
Message-ID: <1453979351-13089-9-git-send-email-cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <1453979351-13089-1-git-send-email-cornelia.huck@de.ibm.com>
From: Halil Pasic <pasic@linux.vnet.ibm.com>
>From the beginning, css support contained an error in csch handling:
instead of setting the clear bit in the function control bits twice, we
need to set the clear pending bit in the activity control bits. Let's
fix this.
Cc: qemu-stable@nongnu.org
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
hw/s390x/css.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/s390x/css.c b/hw/s390x/css.c
index 533357a..e83bf60 100644
--- a/hw/s390x/css.c
+++ b/hw/s390x/css.c
@@ -702,7 +702,7 @@ int css_do_csch(SubchDev *sch)
/* Trigger the clear function. */
s->ctrl &= ~(SCSW_CTRL_MASK_FCTL | SCSW_CTRL_MASK_ACTL);
- s->ctrl |= SCSW_FCTL_CLEAR_FUNC | SCSW_FCTL_CLEAR_FUNC;
+ s->ctrl |= SCSW_FCTL_CLEAR_FUNC | SCSW_ACTL_CLEAR_PEND;
do_subchannel_work(sch, NULL);
ret = 0;
--
2.7.0
next prev parent reply other threads:[~2016-01-28 11:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 11:09 [Qemu-devel] [PULL 00/10] next round of s390x patches Cornelia Huck
2016-01-28 11:09 ` [Qemu-devel] [PULL 01/10] s390x/skeys: Fix instance and class size Cornelia Huck
2016-01-28 11:09 ` [Qemu-devel] [PULL 02/10] s390x/machine: make addon register fields static Cornelia Huck
2016-01-28 11:09 ` [Qemu-devel] [PULL 03/10] s390x/sclp: add device to the sysbus in sclp_realize Cornelia Huck
2016-01-28 11:09 ` [Qemu-devel] [PULL 04/10] s390x/ioinst: set type and len for SEI response Cornelia Huck
2016-01-28 11:09 ` [Qemu-devel] [PULL 05/10] s390x: fix generation of event information crw Cornelia Huck
2016-01-28 11:09 ` [Qemu-devel] [PULL 06/10] watchdog: introduction of get_watchdog_action Cornelia Huck
2016-01-28 11:09 ` [Qemu-devel] [PULL 07/10] watchdog/diag288: don't reset for action=none|debug|pause Cornelia Huck
2016-01-28 11:09 ` Cornelia Huck [this message]
2016-01-28 11:09 ` [Qemu-devel] [PULL 09/10] gdb: provide the name of the architecture in the target.xml Cornelia Huck
2016-01-28 11:09 ` [Qemu-devel] [PULL 10/10] s390x: s390_cpu_get_phys_page_debug has to return -1 Cornelia Huck
2016-01-28 13:41 ` [Qemu-devel] [PULL 00/10] next round of s390x patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453979351-13089-9-git-send-email-cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).