From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40623) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aP9MU-0000PU-TX for qemu-devel@nongnu.org; Fri, 29 Jan 2016 08:45:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aP9MU-0007yJ-2K for qemu-devel@nongnu.org; Fri, 29 Jan 2016 08:45:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40507) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aP9MT-0007y2-Sj for qemu-devel@nongnu.org; Fri, 29 Jan 2016 08:45:17 -0500 Message-ID: <1454075114.14284.2.camel@redhat.com> From: Gerd Hoffmann Date: Fri, 29 Jan 2016 14:45:14 +0100 In-Reply-To: <1454072434-16045-1-git-send-email-ppandit@redhat.com> References: <1454072434-16045-1-git-send-email-ppandit@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] usb: ehci: add capability mmio write function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: P J P Cc: Zuozhi Fzz , QEMU Developers , Prasad J Pandit On Fr, 2016-01-29 at 18:30 +0530, P J P wrote: > From: Prasad J Pandit >=20 > USB Ehci emulation supports host controller capability registers. > But its mmio '.write' function was missing, which lead to a null > pointer dereference issue. Add a do nothing 'ehci_caps_write' > definition to avoid it; Do nothing because capability registers > are Read Only(RO). Surely makes sense, xhci does the same, I'll pick it up. Maybe we should have a generic nop_write function somewhere. Not that there can much go wrong by cut&pasting here, but still ... cheers, Gerd