From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com, armbru@redhat.com,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH v10 09/25] balloon: Improve use of qapi visitor
Date: Fri, 29 Jan 2016 06:48:45 -0700 [thread overview]
Message-ID: <1454075341-13658-10-git-send-email-eblake@redhat.com> (raw)
In-Reply-To: <1454075341-13658-1-git-send-email-eblake@redhat.com>
Rework the control flow of balloon_stats_get_all() to make it
easier for a later patch to split visit_end_struct(). Also
switch to the uint64 visitor to match the data type.
Signed-off-by: Eric Blake <eblake@redhat.com>
---
v10: defer out_nested label to later patch, drop Marc-Andre's R-b
v9: no change
v8: no change
v7: place earlier in series
v6: new patch, split from RFC on v5 7/46
---
hw/virtio/virtio-balloon.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index 9671635..ba1d393 100644
--- a/hw/virtio/virtio-balloon.c
+++ b/hw/virtio/virtio-balloon.c
@@ -130,9 +130,11 @@ static void balloon_stats_get_all(Object *obj, struct Visitor *v,
if (err) {
goto out_end;
}
- for (i = 0; !err && i < VIRTIO_BALLOON_S_NR; i++) {
- visit_type_int64(v, (int64_t *) &s->stats[i], balloon_stat_names[i],
- &err);
+ for (i = 0; i < VIRTIO_BALLOON_S_NR; i++) {
+ visit_type_uint64(v, &s->stats[i], balloon_stat_names[i], &err);
+ if (err) {
+ break;
+ }
}
error_propagate(errp, err);
err = NULL;
--
2.5.0
next prev parent reply other threads:[~2016-01-29 13:49 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 13:48 [Qemu-devel] [PATCH v10 00/25] qapi visitor cleanups part 1 (post-introspection cleanups subset E) Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 01/25] qobject: Document more shortcomings in our number handling Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 02/25] qapi: Avoid use of misnamed DO_UPCAST() Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 03/25] qapi: Drop dead dealloc visitor variable Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 04/25] qapi: Dealloc visitor does not need a type_size() Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 05/25] qapi: Drop dead parameter in gen_params() Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 06/25] hmp: Drop pointless allocation during qapi visit Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 07/25] hmp: Cache use of qapi visitor Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 08/25] vl: Ensure qapi visitor properly ends struct visit Eric Blake
2016-01-29 13:48 ` Eric Blake [this message]
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 10/25] qapi: Improve generated event use of qapi visitor Eric Blake
2016-02-01 12:31 ` Markus Armbruster
2016-02-01 22:50 ` Eric Blake
2016-02-02 7:52 ` Markus Armbruster
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 11/25] qapi: Track all failures between visit_start/stop Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 12/25] qapi-visit: Kill unused visit_end_union() Eric Blake
2016-02-01 12:38 ` Markus Armbruster
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 13/25] qapi: Prefer type_int64 over type_int in visitors Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 14/25] qapi: Make all visitors supply uint64 callbacks Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 15/25] qapi: Consolidate visitor small integer callbacks Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 16/25] qapi: Don't cast Enum* to int* Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 17/25] qom: Use typedef for Visitor Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 18/25] qapi: Swap visit_* arguments for consistent 'name' placement Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 19/25] qom: Swap 'name' next to visitor in ObjectPropertyAccessor Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 20/25] qapi: Swap 'name' in visit_* callbacks to match public API Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 21/25] qapi: Drop unused 'kind' for struct/enum visit Eric Blake
2016-02-01 12:56 ` Markus Armbruster
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 22/25] qapi: Tighten qmp_input_end_list() Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 23/25] qapi: Drop unused error argument for list and implicit struct Eric Blake
2016-02-01 13:07 ` Markus Armbruster
2016-02-01 17:22 ` Eric Blake
2016-02-01 23:14 ` Eric Blake
2016-02-02 9:00 ` Markus Armbruster
2016-01-29 13:49 ` [Qemu-devel] [PATCH v10 24/25] qmp: Fix reference-counting of qnull on empty output visit Eric Blake
2016-01-29 13:49 ` [Qemu-devel] [PATCH v10 25/25] qmp: Don't abuse stack to track qmp-output root Eric Blake
2016-02-01 13:25 ` [Qemu-devel] [PATCH v10 00/25] qapi visitor cleanups part 1 (post-introspection cleanups subset E) Markus Armbruster
2016-02-02 9:55 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454075341-13658-10-git-send-email-eblake@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).