From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41307) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aP9QD-0003U3-OW for qemu-devel@nongnu.org; Fri, 29 Jan 2016 08:49:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aP9QC-0001HG-8g for qemu-devel@nongnu.org; Fri, 29 Jan 2016 08:49:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47362) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aP9QC-0001H6-3k for qemu-devel@nongnu.org; Fri, 29 Jan 2016 08:49:08 -0500 From: Eric Blake Date: Fri, 29 Jan 2016 06:48:40 -0700 Message-Id: <1454075341-13658-5-git-send-email-eblake@redhat.com> In-Reply-To: <1454075341-13658-1-git-send-email-eblake@redhat.com> References: <1454075341-13658-1-git-send-email-eblake@redhat.com> Subject: [Qemu-devel] [PATCH v10 04/25] qapi: Dealloc visitor does not need a type_size() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: marcandre.lureau@redhat.com, armbru@redhat.com, Michael Roth The intent of having the visitor type_size() callback differ from type_uint64() is to allow special handling for sizes; the visitor core gracefully falls back to type_uint64() if there is no need for the distinction. Since the dealloc visitor does nothing for any of the int visits, drop the pointless size handler. Signed-off-by: Eric Blake --- v10: new patch, split out from 10/37 --- qapi/qapi-dealloc-visitor.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/qapi/qapi-dealloc-visitor.c b/qapi/qapi-dealloc-visitor.c index 204de8f..4d1ef93 100644 --- a/qapi/qapi-dealloc-visitor.c +++ b/qapi/qapi-dealloc-visitor.c @@ -158,11 +158,6 @@ static void qapi_dealloc_type_anything(Visitor *v, QObject **obj, } } -static void qapi_dealloc_type_size(Visitor *v, uint64_t *obj, const char *name, - Error **errp) -{ -} - static void qapi_dealloc_type_enum(Visitor *v, int *obj, const char * const strings[], const char *kind, const char *name, @@ -224,7 +219,6 @@ QapiDeallocVisitor *qapi_dealloc_visitor_new(void) v->visitor.type_str = qapi_dealloc_type_str; v->visitor.type_number = qapi_dealloc_type_number; v->visitor.type_any = qapi_dealloc_type_anything; - v->visitor.type_size = qapi_dealloc_type_size; v->visitor.start_union = qapi_dealloc_start_union; QTAILQ_INIT(&v->stack); -- 2.5.0