qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] jobs: remove unused structure
@ 2016-02-01 22:18 John Snow
  2016-02-01 22:21 ` Eric Blake
  2016-02-02  2:19 ` Fam Zheng
  0 siblings, 2 replies; 3+ messages in thread
From: John Snow @ 2016-02-01 22:18 UTC (permalink / raw)
  To: jcody; +Cc: kwolf, John Snow, qemu-devel, qemu-block

Signed-off-by: John Snow <jsnow@redhat.com>
---
 blockjob.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/blockjob.c b/blockjob.c
index 80adb9d..a692142 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -278,14 +278,6 @@ void block_job_iostatus_reset(BlockJob *job)
     }
 }
 
-struct BlockFinishData {
-    BlockJob *job;
-    BlockCompletionFunc *cb;
-    void *opaque;
-    bool cancelled;
-    int ret;
-};
-
 static int block_job_finish_sync(BlockJob *job,
                                  void (*finish)(BlockJob *, Error **errp),
                                  Error **errp)
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] jobs: remove unused structure
  2016-02-01 22:18 [Qemu-devel] [PATCH] jobs: remove unused structure John Snow
@ 2016-02-01 22:21 ` Eric Blake
  2016-02-02  2:19 ` Fam Zheng
  1 sibling, 0 replies; 3+ messages in thread
From: Eric Blake @ 2016-02-01 22:21 UTC (permalink / raw)
  To: John Snow, jcody; +Cc: kwolf, qemu-devel, qemu-block

[-- Attachment #1: Type: text/plain, Size: 872 bytes --]

On 02/01/2016 03:18 PM, John Snow wrote:
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  blockjob.c | 8 --------
>  1 file changed, 8 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/blockjob.c b/blockjob.c
> index 80adb9d..a692142 100644
> --- a/blockjob.c
> +++ b/blockjob.c
> @@ -278,14 +278,6 @@ void block_job_iostatus_reset(BlockJob *job)
>      }
>  }
>  
> -struct BlockFinishData {
> -    BlockJob *job;
> -    BlockCompletionFunc *cb;
> -    void *opaque;
> -    bool cancelled;
> -    int ret;
> -};
> -
>  static int block_job_finish_sync(BlockJob *job,
>                                   void (*finish)(BlockJob *, Error **errp),
>                                   Error **errp)
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] jobs: remove unused structure
  2016-02-01 22:18 [Qemu-devel] [PATCH] jobs: remove unused structure John Snow
  2016-02-01 22:21 ` Eric Blake
@ 2016-02-02  2:19 ` Fam Zheng
  1 sibling, 0 replies; 3+ messages in thread
From: Fam Zheng @ 2016-02-02  2:19 UTC (permalink / raw)
  To: John Snow; +Cc: kwolf, jcody, qemu-devel, qemu-block

On Mon, 02/01 17:18, John Snow wrote:
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  blockjob.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/blockjob.c b/blockjob.c
> index 80adb9d..a692142 100644
> --- a/blockjob.c
> +++ b/blockjob.c
> @@ -278,14 +278,6 @@ void block_job_iostatus_reset(BlockJob *job)
>      }
>  }
>  
> -struct BlockFinishData {
> -    BlockJob *job;
> -    BlockCompletionFunc *cb;
> -    void *opaque;
> -    bool cancelled;
> -    int ret;
> -};
> -

Duplicates this:

https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg05529.html

Fam

>  static int block_job_finish_sync(BlockJob *job,
>                                   void (*finish)(BlockJob *, Error **errp),
>                                   Error **errp)
> -- 
> 2.4.3
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-02-02  2:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-01 22:18 [Qemu-devel] [PATCH] jobs: remove unused structure John Snow
2016-02-01 22:21 ` Eric Blake
2016-02-02  2:19 ` Fam Zheng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).