From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQWL0-0003mZ-Cn for qemu-devel@nongnu.org; Tue, 02 Feb 2016 03:29:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQWKu-0000G6-QD for qemu-devel@nongnu.org; Tue, 02 Feb 2016 03:29:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49605) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQWKu-0000G2-LH for qemu-devel@nongnu.org; Tue, 02 Feb 2016 03:29:20 -0500 Message-ID: <1454401758.9300.38.camel@redhat.com> From: Gerd Hoffmann Date: Tue, 02 Feb 2016 09:29:18 +0100 In-Reply-To: <20160202081312.GA9895@nvidia.com> References: <56AFD231.3010404@nvidia.com> <56B00AD7.6070103@nvidia.com> <1454400043.9300.31.camel@redhat.com> <20160202081312.GA9895@nvidia.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [RFC PATCH v1 1/1] vGPU core driver : to provide common interface for vGPU. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Neo Jia Cc: "Ruan, Shuai" , "Song, Jike" , "kvm@vger.kernel.org" , "Tian, Kevin" , Kirti Wankhede , qemu-devel , Alex Williamson , "Lv, Zhiyuan" , Paolo Bonzini On Di, 2016-02-02 at 00:13 -0800, Neo Jia wrote: > On Tue, Feb 02, 2016 at 09:00:43AM +0100, Gerd Hoffmann wrote: > > Hi, > >=20 > > > And for UUID, I remember Alex had a concern on using it in kernel.= =20 > > > Honestly speaking I don't have a good idea here. In Xen side there is= a VM ID > > > which can be easily used as the index. But for KVM, what would be the= best > > > identifier to associate with a VM? > >=20 > > The vgpu code doesn't need to associate the vgpu device with a vm in th= e > > first place. You get all guest address space information from qemu, vi= a > > vfio iommu interface. > >=20 > > When qemu does't use kvm (tcg mode), things should still work fine. > > Using vfio-based vgpu devices with non-qemu apps (some kind of test > > suite for example) should work fine too. >=20 > Hi Gerd and Kevin, >=20 > I thought Alex had agreed with the UUID as long as it is not tied with VM= , > probably it is just his comment gets lost in our previous long email thre= ad. As long as it isn't tied to a VM it is fine indeed. We'll need names for the devices, and using a uuid certainly is one option. Could also be a simple "vgpu${index}". A more descriptive name such as "nvidia-grid-${index}" or "igd-skl-${index}". Or just a free-form string where the driver can fill whatever it wants (including a uuid). cheers, Gerd