qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: marcandre.lureau@redhat.com
To: qemu-devel@nongnu.org
Cc: claudio.fontana@huawei.com, armbru@redhat.com,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PULL 4/8] libqos: remove some leaks
Date: Tue,  2 Feb 2016 13:43:32 +0100	[thread overview]
Message-ID: <1454417016-3913-5-git-send-email-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <1454417016-3913-1-git-send-email-marcandre.lureau@redhat.com>

From: Marc-André Lureau <marcandre.lureau@redhat.com>

qpci_device_find() returns allocated data, don't leak it.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
---
 tests/libqos/pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/libqos/pci.c b/tests/libqos/pci.c
index 4e630c2..80b1a21 100644
--- a/tests/libqos/pci.c
+++ b/tests/libqos/pci.c
@@ -34,11 +34,13 @@ void qpci_device_foreach(QPCIBus *bus, int vendor_id, int device_id,
 
             if (vendor_id != -1 &&
                 qpci_config_readw(dev, PCI_VENDOR_ID) != vendor_id) {
+                g_free(dev);
                 continue;
             }
 
             if (device_id != -1 &&
                 qpci_config_readw(dev, PCI_DEVICE_ID) != device_id) {
+                g_free(dev);
                 continue;
             }
 
-- 
2.5.0

  parent reply	other threads:[~2016-02-02 12:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-02 12:43 [Qemu-devel] [PULL 0/8] Ivshmem patches marcandre.lureau
2016-02-02 12:43 ` [Qemu-devel] [PULL 1/8] ivshmem: no need for opaque argument marcandre.lureau
2016-02-02 12:43 ` [Qemu-devel] [PULL 2/8] ivshmem: remove redundant assignment, fix crash with msi=off marcandre.lureau
2016-02-02 12:43 ` [Qemu-devel] [PULL 3/8] ivshmem-test: leak fixes marcandre.lureau
2016-02-02 12:43 ` marcandre.lureau [this message]
2016-02-02 12:43 ` [Qemu-devel] [PULL 5/8] ivshmem-test: test both msi & irq cases marcandre.lureau
2016-02-02 12:43 ` [Qemu-devel] [PULL 6/8] ivshmem: generalize ivshmem_setup_interrupts marcandre.lureau
2016-02-02 12:43 ` [Qemu-devel] [PULL 7/8] ivshmem: use a single eventfd callback, get rid of CharDriver marcandre.lureau
2016-02-02 12:43 ` [Qemu-devel] [PULL 8/8] char: remove qemu_chr_open_eventfd marcandre.lureau
2016-02-02 14:25 ` [Qemu-devel] [PULL 0/8] Ivshmem patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454417016-3913-5-git-send-email-marcandre.lureau@redhat.com \
    --to=marcandre.lureau@redhat.com \
    --cc=armbru@redhat.com \
    --cc=claudio.fontana@huawei.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).