From: marcandre.lureau@redhat.com
To: qemu-devel@nongnu.org
Cc: claudio.fontana@huawei.com, armbru@redhat.com,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PULL 8/8] char: remove qemu_chr_open_eventfd
Date: Tue, 2 Feb 2016 13:43:36 +0100 [thread overview]
Message-ID: <1454417016-3913-9-git-send-email-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <1454417016-3913-1-git-send-email-marcandre.lureau@redhat.com>
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Broken since d0d7708ba29cbc, since the backend is NULL.
And now no longer needed by ivshmem.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
---
include/sysemu/char.h | 3 ---
qemu-char.c | 13 -------------
2 files changed, 16 deletions(-)
diff --git a/include/sysemu/char.h b/include/sysemu/char.h
index 598dd2b..e035d1c 100644
--- a/include/sysemu/char.h
+++ b/include/sysemu/char.h
@@ -360,9 +360,6 @@ void register_char_driver(const char *name, ChardevBackendKind kind,
CharDriverState *(*create)(const char *id, ChardevBackend *backend,
ChardevReturn *ret, Error **errp));
-/* add an eventfd to the qemu devices that are polled */
-CharDriverState *qemu_chr_open_eventfd(int eventfd);
-
extern int term_escape_char;
CharDriverState *qemu_char_get_next_serial(void);
diff --git a/qemu-char.c b/qemu-char.c
index ca53e8c..1605b30 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2838,19 +2838,6 @@ static int tcp_chr_sync_read(CharDriverState *chr, const uint8_t *buf, int len)
return size;
}
-#ifndef _WIN32
-CharDriverState *qemu_chr_open_eventfd(int eventfd)
-{
- CharDriverState *chr = qemu_chr_open_fd(eventfd, eventfd, NULL, NULL);
-
- if (chr) {
- chr->avail_connections = 1;
- }
-
- return chr;
-}
-#endif
-
static void tcp_chr_connect(void *opaque)
{
CharDriverState *chr = opaque;
--
2.5.0
next prev parent reply other threads:[~2016-02-02 12:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 12:43 [Qemu-devel] [PULL 0/8] Ivshmem patches marcandre.lureau
2016-02-02 12:43 ` [Qemu-devel] [PULL 1/8] ivshmem: no need for opaque argument marcandre.lureau
2016-02-02 12:43 ` [Qemu-devel] [PULL 2/8] ivshmem: remove redundant assignment, fix crash with msi=off marcandre.lureau
2016-02-02 12:43 ` [Qemu-devel] [PULL 3/8] ivshmem-test: leak fixes marcandre.lureau
2016-02-02 12:43 ` [Qemu-devel] [PULL 4/8] libqos: remove some leaks marcandre.lureau
2016-02-02 12:43 ` [Qemu-devel] [PULL 5/8] ivshmem-test: test both msi & irq cases marcandre.lureau
2016-02-02 12:43 ` [Qemu-devel] [PULL 6/8] ivshmem: generalize ivshmem_setup_interrupts marcandre.lureau
2016-02-02 12:43 ` [Qemu-devel] [PULL 7/8] ivshmem: use a single eventfd callback, get rid of CharDriver marcandre.lureau
2016-02-02 12:43 ` marcandre.lureau [this message]
2016-02-02 14:25 ` [Qemu-devel] [PULL 0/8] Ivshmem patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454417016-3913-9-git-send-email-marcandre.lureau@redhat.com \
--to=marcandre.lureau@redhat.com \
--cc=armbru@redhat.com \
--cc=claudio.fontana@huawei.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).