From: Gerd Hoffmann <kraxel@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: seabios@seabios.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [SeaBIOS] [RFC PATCH v2] fw/pci: Add support for mapping Intel IGD OpRegion via QEMU
Date: Wed, 03 Feb 2016 10:04:08 +0100 [thread overview]
Message-ID: <1454490248.4967.51.camel@redhat.com> (raw)
In-Reply-To: <20160202201023.5353.65948.stgit@gimli.home>
Hi,
> +static void intel_igd_opregion_setup(struct pci_device *dev, void *arg)
> +{
> + struct romfile_s *file = romfile_find("etc/igd-opregion");
Is it possible to have multiple igd devices in a single machine?
So, should we include the pci address in the file name?
Guess not needed, it's chipset graphics after all ...
> + pci_config_writel(bdf, 0xFC, cpu_to_le32((u32)opregion));
Looks a bit funny in code which is never ever going to run on big endian
machines ;)
Patch looks good to me.
cheers,
Gerd
next prev parent reply other threads:[~2016-02-03 9:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 20:10 [Qemu-devel] [RFC PATCH v2] fw/pci: Add support for mapping Intel IGD OpRegion via QEMU Alex Williamson
2016-02-03 9:04 ` Gerd Hoffmann [this message]
2016-02-03 19:43 ` [Qemu-devel] [SeaBIOS] " Alex Williamson
2016-02-03 21:38 ` Alex Williamson
2016-02-03 22:09 ` Kevin O'Connor
2016-02-03 23:52 ` Alex Williamson
2016-02-04 7:52 ` Gerd Hoffmann
2016-02-04 16:01 ` Kevin O'Connor
2016-02-04 16:58 ` Igor Mammedov
2016-02-05 5:44 ` Alex Williamson
2016-02-05 7:58 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454490248.4967.51.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).