From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQtMF-0002tW-SH for qemu-devel@nongnu.org; Wed, 03 Feb 2016 04:04:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQtMB-0000rq-TE for qemu-devel@nongnu.org; Wed, 03 Feb 2016 04:04:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58096) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQtMB-0000rk-NN for qemu-devel@nongnu.org; Wed, 03 Feb 2016 04:04:11 -0500 Message-ID: <1454490248.4967.51.camel@redhat.com> From: Gerd Hoffmann Date: Wed, 03 Feb 2016 10:04:08 +0100 In-Reply-To: <20160202201023.5353.65948.stgit@gimli.home> References: <20160202201023.5353.65948.stgit@gimli.home> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [SeaBIOS] [RFC PATCH v2] fw/pci: Add support for mapping Intel IGD OpRegion via QEMU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: seabios@seabios.org, qemu-devel@nongnu.org Hi, > +static void intel_igd_opregion_setup(struct pci_device *dev, void *arg) > +{ > + struct romfile_s *file =3D romfile_find("etc/igd-opregion"); Is it possible to have multiple igd devices in a single machine? So, should we include the pci address in the file name? Guess not needed, it's chipset graphics after all ... > + pci_config_writel(bdf, 0xFC, cpu_to_le32((u32)opregion)); Looks a bit funny in code which is never ever going to run on big endian machines ;) Patch looks good to me. cheers, Gerd