From: Gerd Hoffmann <kraxel@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: "Marc Marí" <marc.mari.barcelo@gmail.com>,
"Gabriel L. Somlo" <somlo@cmu.edu>,
qemu-devel@nongnu.org, "Kevin O'Connor" <kevin@koconnor.net>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc Marí" <markmb@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4] Add optionrom compatible with fw_cfg DMA version
Date: Wed, 03 Feb 2016 13:57:06 +0100 [thread overview]
Message-ID: <1454504226.4967.66.camel@redhat.com> (raw)
In-Reply-To: <56B1E92B.4050705@redhat.com>
Hi,
> >> I agree that DMA capability should be filtered with machine type.
> >> However, that distinction should not be made using the current
> >> "dma_enabled" properties (i.e., of "fw_cfg_io_properties" and
> >> "fw_cfg_mem_properties". Instead, it should be made in the
> >> board-specific callers of fw_cfg_init_(io_dma|mem_wide).
> >
> > Why?
>
> That's how "has_reserved_memory" works as well, for example.
Those are machine options, not device options. If we have a device
property there is no need to create a duplicate a machine option for the
same purpose.
> But, if the property is made work, I guess PC_COMPAT_2_4 can be used
> too. (Or should it be HW_COMPAT_2_4?)
HW_COMPAT_2_4 probably, so it applies to q35 too.
cheers,
Gerd
next prev parent reply other threads:[~2016-02-03 12:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 11:12 [Qemu-devel] [PATCH v4] Add optionrom compatible with fw_cfg DMA version Marc Marí
2016-01-29 15:25 ` Stefan Hajnoczi
2016-02-02 11:06 ` Gerd Hoffmann
2016-02-02 12:04 ` Gerd Hoffmann
2016-02-02 13:07 ` Marc Marí
2016-02-02 14:23 ` Gerd Hoffmann
2016-02-02 15:04 ` Laszlo Ersek
2016-02-03 8:44 ` Gerd Hoffmann
2016-02-03 11:48 ` Laszlo Ersek
2016-02-03 12:57 ` Gerd Hoffmann [this message]
2016-02-02 12:58 ` Marc Marí
2016-02-03 9:47 ` Stefan Hajnoczi
2016-02-22 11:56 ` Vladimir Sementsov-Ogievskiy
2016-02-23 9:51 ` Stefan Hajnoczi
2016-03-21 11:14 ` Richard W.M. Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454504226.4967.66.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=kevin@koconnor.net \
--cc=lersek@redhat.com \
--cc=marc.mari.barcelo@gmail.com \
--cc=markmb@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=somlo@cmu.edu \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).