From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37660)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1aQwzh-0000pW-Jk
	for qemu-devel@nongnu.org; Wed, 03 Feb 2016 07:57:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1aQwze-0000Us-DR
	for qemu-devel@nongnu.org; Wed, 03 Feb 2016 07:57:13 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39522)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1aQwze-0000Uh-0l
	for qemu-devel@nongnu.org; Wed, 03 Feb 2016 07:57:10 -0500
Message-ID: <1454504226.4967.66.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 03 Feb 2016 13:57:06 +0100
In-Reply-To: <56B1E92B.4050705@redhat.com>
References: <1454065944-15887-1-git-send-email-markmb@redhat.com>
	<1454411187.9300.54.camel@redhat.com>
	<1454414695.9300.57.camel@redhat.com>
	<20160202140733.6cef6568@crunchbang>
	<1454423012.9300.99.camel@redhat.com>
	<56B0C59A.6070008@redhat.com> <1454489075.4967.45.camel@redhat.com>
	<56B1E92B.4050705@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v4] Add optionrom compatible with fw_cfg
 DMA version
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Marc =?ISO-8859-1?Q?Mar=ED?= <marc.mari.barcelo@gmail.com>, "Gabriel L.
	Somlo" <somlo@cmu.edu>, qemu-devel@nongnu.org, Kevin O'Connor <kevin@koconnor.net>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Marc =?ISO-8859-1?Q?Mar=ED?= <markmb@redhat.com>

  Hi,

> >> I agree that DMA capability should be filtered with machine type.
> >> However, that distinction should not be made using the current
> >> "dma_enabled" properties (i.e., of "fw_cfg_io_properties" and
> >> "fw_cfg_mem_properties". Instead, it should be made in the
> >> board-specific callers of fw_cfg_init_(io_dma|mem_wide).
> >=20
> > Why?
>=20
> That's how "has_reserved_memory" works as well, for example.

Those are machine options, not device options.  If we have a device
property there is no need to create a duplicate a machine option for the
same purpose.

> But, if the property is made work, I guess PC_COMPAT_2_4 can be used
> too. (Or should it be HW_COMPAT_2_4?)

HW_COMPAT_2_4 probably, so it applies to q35 too.

cheers,
  Gerd