From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aR0N2-00073H-2f for qemu-devel@nongnu.org; Wed, 03 Feb 2016 11:33:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aR0My-0007n5-5S for qemu-devel@nongnu.org; Wed, 03 Feb 2016 11:33:32 -0500 From: Max Reitz Date: Wed, 3 Feb 2016 17:33:15 +0100 Message-Id: <1454517196-4560-2-git-send-email-mreitz@redhat.com> In-Reply-To: <1454517196-4560-1-git-send-email-mreitz@redhat.com> References: <1454517196-4560-1-git-send-email-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH 1/2] block/nbd: Reject port parameter without host List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: Kevin Wolf , qemu-devel@nongnu.org, Markus Armbruster , Paolo Bonzini , Max Reitz This is better than the generic block layer finding out later that the port parameter has not been used. Signed-off-by: Max Reitz --- block/nbd.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/block/nbd.c b/block/nbd.c index 1a90bc7..063c403 100644 --- a/block/nbd.c +++ b/block/nbd.c @@ -201,6 +201,10 @@ static SocketAddress *nbd_config(BDRVNBDState *s, QDict *options, char **export, } return NULL; } + if (qdict_haskey(options, "port") && !qdict_haskey(options, "host")) { + error_setg(errp, "port may not be used without host."); + return NULL; + } saddr = g_new0(SocketAddress, 1); -- 2.7.0