qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, jsnow@redhat.com,
	"Hervé Poussineau" <hpoussin@reactos.org>
Subject: [Qemu-devel] [PULL 15/20] sparc64: disable floppy DMA
Date: Wed,  3 Feb 2016 15:32:30 -0500	[thread overview]
Message-ID: <1454531555-32022-16-git-send-email-jsnow@redhat.com> (raw)
In-Reply-To: <1454531555-32022-1-git-send-email-jsnow@redhat.com>

From: Hervé Poussineau <hpoussin@reactos.org>

All functions relative to DMA (DMA_*() functions) are stubs on sparc64 platform.
Disable the DMA of the floppy controller, instead of calling these stubs.

Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
Message-id: 1453843944-26833-15-git-send-email-hpoussin@reactos.org
Signed-off-by: John Snow <jsnow@redhat.com>
---
 hw/sparc64/sun4u.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c
index d356717..371f5bc 100644
--- a/hw/sparc64/sun4u.c
+++ b/hw/sparc64/sun4u.c
@@ -816,6 +816,7 @@ static void sun4uv_init(MemoryRegion *address_space_mem,
     qemu_irq *ivec_irqs, *pbm_irqs;
     DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS];
     DriveInfo *fd[MAX_FD];
+    DeviceState *dev;
     FWCfgState *fw_cfg;
 
     /* init CPUs */
@@ -852,10 +853,22 @@ static void sun4uv_init(MemoryRegion *address_space_mem,
     pci_cmd646_ide_init(pci_bus, hd, 1);
 
     isa_create_simple(isa_bus, "i8042");
+
+    /* Floppy */
     for(i = 0; i < MAX_FD; i++) {
         fd[i] = drive_get(IF_FLOPPY, 0, i);
     }
-    fdctrl_init_isa(isa_bus, fd);
+    dev = DEVICE(isa_create(isa_bus, TYPE_ISA_FDC));
+    if (fd[0]) {
+        qdev_prop_set_drive(dev, "driveA", blk_by_legacy_dinfo(fd[0]),
+                            &error_abort);
+    }
+    if (fd[1]) {
+        qdev_prop_set_drive(dev, "driveB", blk_by_legacy_dinfo(fd[1]),
+                            &error_abort);
+    }
+    qdev_prop_set_uint32(dev, "dma", -1);
+    qdev_init_nofail(dev);
 
     /* Map NVRAM into I/O (ebus) space */
     nvram = m48t59_init(NULL, 0, 0, NVRAM_SIZE, 1968, 59);
-- 
2.4.3

  parent reply	other threads:[~2016-02-03 20:32 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-03 20:32 [Qemu-devel] [PULL 00/20] FDC patches John Snow
2016-02-03 20:32 ` [Qemu-devel] [PULL 01/20] fdc: fix detection under Linux John Snow
2016-02-03 20:32 ` [Qemu-devel] [PULL 02/20] i82374: device only existed as ISA device, so simplify device John Snow
2016-02-03 20:32 ` [Qemu-devel] [PULL 03/20] i8257: pass ISA bus to DMA_init() function John Snow
2016-02-03 20:32 ` [Qemu-devel] [PULL 04/20] i8257: rename struct dma_cont to I8257State John Snow
2016-02-03 20:32 ` [Qemu-devel] [PULL 05/20] i8257: rename struct dma_regs to I8257Regs John Snow
2016-02-03 20:32 ` [Qemu-devel] [PULL 06/20] i8257: rename functions to start with i8257_ prefix John Snow
2016-02-03 20:32 ` [Qemu-devel] [PULL 07/20] i8257: make the DMA running method per controller John Snow
2016-02-03 20:32 ` [Qemu-devel] [PULL 08/20] i8257: add missing const John Snow
2016-02-03 20:32 ` [Qemu-devel] [PULL 09/20] i8257: QOM'ify John Snow
2016-02-03 20:32 ` [Qemu-devel] [PULL 10/20] i8257: move state definition to new independent header John Snow
2016-02-03 20:32 ` [Qemu-devel] [PULL 11/20] isa: add an ISA DMA interface, and store it within the ISA bus John Snow
2016-02-03 20:32 ` [Qemu-devel] [PULL 12/20] i8257: implement the IsaDma interface John Snow
2016-02-03 20:32 ` [Qemu-devel] [PULL 13/20] magnum: disable floppy DMA for now John Snow
2016-02-03 20:32 ` [Qemu-devel] [PULL 14/20] sparc: disable floppy DMA John Snow
2016-02-03 20:32 ` John Snow [this message]
2016-02-03 20:32 ` [Qemu-devel] [PULL 16/20] fdc: use IsaDma interface instead of global DMA_* functions John Snow
2016-02-03 20:32 ` [Qemu-devel] [PULL 17/20] cs4231a: " John Snow
2016-02-03 20:32 ` [Qemu-devel] [PULL 18/20] gus: " John Snow
2016-02-03 20:32 ` [Qemu-devel] [PULL 19/20] sb16: " John Snow
2016-02-03 20:32 ` [Qemu-devel] [PULL 20/20] dma: remove now useless " John Snow
2016-02-04 14:16 ` [Qemu-devel] [PULL 00/20] FDC patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454531555-32022-16-git-send-email-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=hpoussin@reactos.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).