From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50683) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aR58W-0007bR-NJ for qemu-devel@nongnu.org; Wed, 03 Feb 2016 16:38:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aR58T-0003r5-Hr for qemu-devel@nongnu.org; Wed, 03 Feb 2016 16:38:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39969) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aR58T-0003qy-Ck for qemu-devel@nongnu.org; Wed, 03 Feb 2016 16:38:49 -0500 Message-ID: <1454535527.2989.1.camel@redhat.com> From: Alex Williamson Date: Wed, 03 Feb 2016 14:38:47 -0700 In-Reply-To: <1454528580.18969.10.camel@redhat.com> References: <20160202201023.5353.65948.stgit@gimli.home> <1454490248.4967.51.camel@redhat.com> <1454528580.18969.10.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [SeaBIOS] [RFC PATCH v2] fw/pci: Add support for mapping Intel IGD OpRegion via QEMU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: seabios@seabios.org, qemu-devel@nongnu.org On Wed, 2016-02-03 at 12:43 -0700, Alex Williamson wrote: > On Wed, 2016-02-03 at 10:04 +0100, Gerd Hoffmann wrote: > > =C2=A0 Hi, > > =C2=A0 > > > +static void intel_igd_opregion_setup(struct pci_device *dev, void = *arg) > > > +{ > > > +=C2=A0=C2=A0=C2=A0=C2=A0struct romfile_s *file =3D romfile_find("e= tc/igd-opregion"); > > =C2=A0 > > Is it possible to have multiple igd devices in a single machine? > > So, should we include the pci address in the file name? > > =C2=A0 > > Guess not needed, it's chipset graphics after all ... >=C2=A0 > Hmm, I think that's probably a pretty good observation, we don't want t= o > revisit this if vGPUs need/want an OpRegion or if Intel decides to star= t > allowing more than one per system.=C2=A0=C2=A0Either could pretty easil= y introduce > multiple into a VM. Naming is always more complicated than it seems.=C2=A0=C2=A0For anything = other than a root bus devices, the PCI address doesn't exist until SeaBIOS enumerates devices and assigns bus numbers for bridges.=C2=A0=C2=A0So unl= ess we want to provide a path to the device like ACPI defines, maybe we should just stick with "etc/igd-opregion".=C2=A0=C2=A0It seems easily extensible= to add more specific files later and default to this one if those aren't found. Thanks, Alex