From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aR7A8-0006Is-Vo for qemu-devel@nongnu.org; Wed, 03 Feb 2016 18:48:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aR7A8-0000nn-5L for qemu-devel@nongnu.org; Wed, 03 Feb 2016 18:48:40 -0500 From: John Snow Date: Wed, 3 Feb 2016 18:48:33 -0500 Message-Id: <1454543313-17505-1-git-send-email-jsnow@redhat.com> Subject: [Qemu-devel] [PATCH] nbd: avoid unaligned uint64_t store List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: John Snow , pbonzini@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com cpu_to_be64w can't be used to make unaligned stores, but stq_be_p can. The other stores in this routine are left alone, they're aligned already. Signed-off-by: John Snow --- nbd/server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nbd/server.c b/nbd/server.c index 1ec79cf..5b65059 100644 --- a/nbd/server.c +++ b/nbd/server.c @@ -441,7 +441,7 @@ static coroutine_fn int nbd_negotiate(NBDClientNewData *data) } assert ((client->exp->nbdflags & ~65535) == 0); - cpu_to_be64w((uint64_t*)(buf + 18), client->exp->size); + stq_be_p((uint64_t *)(buf + 18), client->exp->size); cpu_to_be16w((uint16_t*)(buf + 26), client->exp->nbdflags | myflags); if (nbd_negotiate_write(csock, buf + 18, sizeof(buf) - 18) != sizeof(buf) - 18) { -- 2.4.3