qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: peter.maydell@linaro.org, qemu-devel@nongnu.org
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Jason Wang <jasowang@redhat.com>,
	Guillaume Subiron <maethor@subiron.org>
Subject: [Qemu-devel] [PULL V2 13/17] slirp: Adding family argument to tcp_fconnect()
Date: Thu,  4 Feb 2016 16:31:42 +0800	[thread overview]
Message-ID: <1454574706-5681-14-git-send-email-jasowang@redhat.com> (raw)
In-Reply-To: <1454574706-5681-1-git-send-email-jasowang@redhat.com>

From: Guillaume Subiron <maethor@subiron.org>

This patch simply adds a unsigned short family argument to remove the hardcoded
"AF_INET" in the call of qemu_socket().

This prepares for IPv6 support.

Signed-off-by: Guillaume Subiron <maethor@subiron.org>
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 slirp/slirp.h     | 2 +-
 slirp/tcp_input.c | 2 +-
 slirp/tcp_subr.c  | 5 +++--
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/slirp/slirp.h b/slirp/slirp.h
index ec0a4c2..239fe29 100644
--- a/slirp/slirp.h
+++ b/slirp/slirp.h
@@ -327,7 +327,7 @@ void tcp_respond(struct tcpcb *, register struct tcpiphdr *, register struct mbu
 struct tcpcb * tcp_newtcpcb(struct socket *);
 struct tcpcb * tcp_close(register struct tcpcb *);
 void tcp_sockclosed(struct tcpcb *);
-int tcp_fconnect(struct socket *);
+int tcp_fconnect(struct socket *, unsigned short af);
 void tcp_connect(struct socket *);
 int tcp_attach(struct socket *);
 uint8_t tcp_tos(struct socket *);
diff --git a/slirp/tcp_input.c b/slirp/tcp_input.c
index 5e2773c..f24e706 100644
--- a/slirp/tcp_input.c
+++ b/slirp/tcp_input.c
@@ -584,7 +584,7 @@ findso:
 	    goto cont_input;
 	  }
 
-          if ((tcp_fconnect(so) == -1) &&
+	  if ((tcp_fconnect(so, so->so_ffamily) == -1) &&
 #if defined(_WIN32)
               socket_error() != WSAEWOULDBLOCK
 #else
diff --git a/slirp/tcp_subr.c b/slirp/tcp_subr.c
index 76c716f..36e3256 100644
--- a/slirp/tcp_subr.c
+++ b/slirp/tcp_subr.c
@@ -324,14 +324,15 @@ tcp_sockclosed(struct tcpcb *tp)
  * nonblocking.  Connect returns after the SYN is sent, and does
  * not wait for ACK+SYN.
  */
-int tcp_fconnect(struct socket *so)
+int tcp_fconnect(struct socket *so, unsigned short af)
 {
   int ret=0;
 
   DEBUG_CALL("tcp_fconnect");
   DEBUG_ARG("so = %p", so);
 
-  if( (ret = so->s = qemu_socket(AF_INET,SOCK_STREAM,0)) >= 0) {
+  ret = so->s = qemu_socket(af, SOCK_STREAM, 0);
+  if (ret >= 0) {
     int opt, s=so->s;
     struct sockaddr_storage addr;
 
-- 
2.5.0

  parent reply	other threads:[~2016-02-04  8:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-04  8:31 [Qemu-devel] [PULL V2 00/17] Net patches Jason Wang
2016-02-04  8:31 ` [Qemu-devel] [PULL V2 01/17] net/slirp: Tell the users when they are using deprecated options Jason Wang
2016-02-04  8:31 ` [Qemu-devel] [PULL V2 02/17] qemu-doc: Do not promote deprecated -smb and -redir options Jason Wang
2016-02-04  8:31 ` [Qemu-devel] [PULL V2 03/17] net: cadence_gem: check packet size in gem_recieve Jason Wang
2016-02-04  8:31 ` [Qemu-devel] [PULL V2 04/17] cadence_gem: fix buffer overflow Jason Wang
2016-02-04  8:31 ` [Qemu-devel] [PULL V2 05/17] slirp: goto bad in udp_input if sosendto fails Jason Wang
2016-02-04  8:31 ` [Qemu-devel] [PULL V2 06/17] slirp: Generalizing and neutralizing ARP code Jason Wang
2016-02-04  8:31 ` [Qemu-devel] [PULL V2 07/17] slirp: Adding address family switch for produced frames Jason Wang
2016-02-04  8:31 ` [Qemu-devel] [PULL V2 08/17] slirp: Make Socket structure IPv6 compatible Jason Wang
2016-02-04  8:31 ` [Qemu-devel] [PULL V2 09/17] slirp: Factorizing address translation Jason Wang
2016-02-04  8:31 ` [Qemu-devel] [PULL V2 10/17] slirp: Factorizing and cleaning solookup() Jason Wang
2016-02-04  8:31 ` [Qemu-devel] [PULL V2 11/17] slirp: Add sockaddr_equal, make solookup family-agnostic Jason Wang
2016-02-04  8:31 ` [Qemu-devel] [PULL V2 12/17] slirp: Make udp_attach IPv6 compatible Jason Wang
2016-02-04  8:31 ` Jason Wang [this message]
2016-02-04  8:31 ` [Qemu-devel] [PULL V2 14/17] e1000: eliminate infinite loops on out-of-bounds transfer start Jason Wang
2016-02-04  8:31 ` [Qemu-devel] [PULL V2 15/17] net: netmap: use nm_open() to open netmap ports Jason Wang
2016-02-04  8:31 ` [Qemu-devel] [PULL V2 16/17] net: always walk through filters in reverse if traffic is egress Jason Wang
2016-02-04  8:31 ` [Qemu-devel] [PULL V2 17/17] net/filter: Fix the output information for command 'info network' Jason Wang
2016-02-04 16:15 ` [Qemu-devel] [PULL V2 00/17] Net patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454574706-5681-14-git-send-email-jasowang@redhat.com \
    --to=jasowang@redhat.com \
    --cc=maethor@subiron.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=samuel.thibault@ens-lyon.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).