From: Jason Wang <jasowang@redhat.com>
To: peter.maydell@linaro.org, qemu-devel@nongnu.org
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>,
Jason Wang <jasowang@redhat.com>,
Guillaume Subiron <maethor@subiron.org>
Subject: [Qemu-devel] [PULL V2 06/17] slirp: Generalizing and neutralizing ARP code
Date: Thu, 4 Feb 2016 16:31:35 +0800 [thread overview]
Message-ID: <1454574706-5681-7-git-send-email-jasowang@redhat.com> (raw)
In-Reply-To: <1454574706-5681-1-git-send-email-jasowang@redhat.com>
From: Guillaume Subiron <maethor@subiron.org>
Basically, this patch replaces "arp" by "resolution" every time "arp"
means "mac resolution" and not specifically ARP.
This prepares for IPv6 support.
Signed-off-by: Guillaume Subiron <maethor@subiron.org>
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
slirp/mbuf.c | 2 +-
slirp/mbuf.h | 2 +-
slirp/slirp.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/slirp/mbuf.c b/slirp/mbuf.c
index 795fc29..bc942b6 100644
--- a/slirp/mbuf.c
+++ b/slirp/mbuf.c
@@ -91,7 +91,7 @@ m_get(Slirp *slirp)
m->m_len = 0;
m->m_nextpkt = NULL;
m->m_prevpkt = NULL;
- m->arp_requested = false;
+ m->resolution_requested = false;
m->expiration_date = (uint64_t)-1;
end_error:
DEBUG_ARG("m = %p", m);
diff --git a/slirp/mbuf.h b/slirp/mbuf.h
index b144f1c..38fedf4 100644
--- a/slirp/mbuf.h
+++ b/slirp/mbuf.h
@@ -79,7 +79,7 @@ struct mbuf {
int m_len; /* Amount of data in this mbuf */
Slirp *slirp;
- bool arp_requested;
+ bool resolution_requested;
uint64_t expiration_date;
/* start of dynamic buffer area, must be last element */
union {
diff --git a/slirp/slirp.c b/slirp/slirp.c
index 35f819a..1d5d172 100644
--- a/slirp/slirp.c
+++ b/slirp/slirp.c
@@ -786,7 +786,7 @@ int if_encap(Slirp *slirp, struct mbuf *ifm)
struct ethhdr *reh = (struct ethhdr *)arp_req;
struct arphdr *rah = (struct arphdr *)(arp_req + ETH_HLEN);
- if (!ifm->arp_requested) {
+ if (!ifm->resolution_requested) {
/* If the client addr is not known, send an ARP request */
memset(reh->h_dest, 0xff, ETH_ALEN);
memcpy(reh->h_source, special_ethaddr, ETH_ALEN - 4);
@@ -812,7 +812,7 @@ int if_encap(Slirp *slirp, struct mbuf *ifm)
rah->ar_tip = iph->ip_dst.s_addr;
slirp->client_ipaddr = iph->ip_dst;
slirp_output(slirp->opaque, arp_req, sizeof(arp_req));
- ifm->arp_requested = true;
+ ifm->resolution_requested = true;
/* Expire request and drop outgoing packet after 1 second */
ifm->expiration_date = qemu_clock_get_ns(QEMU_CLOCK_REALTIME) + 1000000000ULL;
--
2.5.0
next prev parent reply other threads:[~2016-02-04 8:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-04 8:31 [Qemu-devel] [PULL V2 00/17] Net patches Jason Wang
2016-02-04 8:31 ` [Qemu-devel] [PULL V2 01/17] net/slirp: Tell the users when they are using deprecated options Jason Wang
2016-02-04 8:31 ` [Qemu-devel] [PULL V2 02/17] qemu-doc: Do not promote deprecated -smb and -redir options Jason Wang
2016-02-04 8:31 ` [Qemu-devel] [PULL V2 03/17] net: cadence_gem: check packet size in gem_recieve Jason Wang
2016-02-04 8:31 ` [Qemu-devel] [PULL V2 04/17] cadence_gem: fix buffer overflow Jason Wang
2016-02-04 8:31 ` [Qemu-devel] [PULL V2 05/17] slirp: goto bad in udp_input if sosendto fails Jason Wang
2016-02-04 8:31 ` Jason Wang [this message]
2016-02-04 8:31 ` [Qemu-devel] [PULL V2 07/17] slirp: Adding address family switch for produced frames Jason Wang
2016-02-04 8:31 ` [Qemu-devel] [PULL V2 08/17] slirp: Make Socket structure IPv6 compatible Jason Wang
2016-02-04 8:31 ` [Qemu-devel] [PULL V2 09/17] slirp: Factorizing address translation Jason Wang
2016-02-04 8:31 ` [Qemu-devel] [PULL V2 10/17] slirp: Factorizing and cleaning solookup() Jason Wang
2016-02-04 8:31 ` [Qemu-devel] [PULL V2 11/17] slirp: Add sockaddr_equal, make solookup family-agnostic Jason Wang
2016-02-04 8:31 ` [Qemu-devel] [PULL V2 12/17] slirp: Make udp_attach IPv6 compatible Jason Wang
2016-02-04 8:31 ` [Qemu-devel] [PULL V2 13/17] slirp: Adding family argument to tcp_fconnect() Jason Wang
2016-02-04 8:31 ` [Qemu-devel] [PULL V2 14/17] e1000: eliminate infinite loops on out-of-bounds transfer start Jason Wang
2016-02-04 8:31 ` [Qemu-devel] [PULL V2 15/17] net: netmap: use nm_open() to open netmap ports Jason Wang
2016-02-04 8:31 ` [Qemu-devel] [PULL V2 16/17] net: always walk through filters in reverse if traffic is egress Jason Wang
2016-02-04 8:31 ` [Qemu-devel] [PULL V2 17/17] net/filter: Fix the output information for command 'info network' Jason Wang
2016-02-04 16:15 ` [Qemu-devel] [PULL V2 00/17] Net patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454574706-5681-7-git-send-email-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=maethor@subiron.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).