From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSpEH-000406-C6 for qemu-devel@nongnu.org; Mon, 08 Feb 2016 12:04:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSpED-0006vQ-IJ for qemu-devel@nongnu.org; Mon, 08 Feb 2016 12:04:01 -0500 Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:37612) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSpED-0006v2-7M for qemu-devel@nongnu.org; Mon, 08 Feb 2016 12:03:57 -0500 Received: by mail-wm0-x22c.google.com with SMTP id g62so125522631wme.0 for ; Mon, 08 Feb 2016 09:03:57 -0800 (PST) Received: from 640k.lan (94-39-141-130.adsl-ull.clienti.tiscali.it. [94.39.141.130]) by smtp.gmail.com with ESMTPSA id b1sm30651442wjy.0.2016.02.08.09.03.55 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Feb 2016 09:03:56 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Mon, 8 Feb 2016 18:03:17 +0100 Message-Id: <1454950999-64128-27-git-send-email-pbonzini@redhat.com> In-Reply-To: <1454950999-64128-1-git-send-email-pbonzini@redhat.com> References: <1454950999-64128-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 26/28] ipmi: do not take/drop iothread lock List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is not necessary and actually causes a hang; it was probably copied and pasted from KVM code, that is one of the very few places that run outside iothread lock. Signed-off-by: Paolo Bonzini --- hw/ipmi/ipmi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/ipmi/ipmi.c b/hw/ipmi/ipmi.c index dfab272..6adec1e 100644 --- a/hw/ipmi/ipmi.c +++ b/hw/ipmi/ipmi.c @@ -51,9 +51,7 @@ static int ipmi_do_hw_op(IPMIInterface *s, enum ipmi_op op, int checkonly) if (checkonly) { return 0; } - qemu_mutex_lock_iothread(); qmp_inject_nmi(NULL); - qemu_mutex_unlock_iothread(); return 0; case IPMI_POWERCYCLE_CHASSIS: -- 1.8.3.1