From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52332) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aT60x-0002Jv-Oe for qemu-devel@nongnu.org; Tue, 09 Feb 2016 05:59:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aT60u-00021k-Jx for qemu-devel@nongnu.org; Tue, 09 Feb 2016 05:59:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43213) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aT60u-00021g-EJ for qemu-devel@nongnu.org; Tue, 09 Feb 2016 05:59:20 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id EA9CF3B759 for ; Tue, 9 Feb 2016 10:59:19 +0000 (UTC) From: Paolo Bonzini Date: Tue, 9 Feb 2016 11:59:15 +0100 Message-Id: <1455015557-15106-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH] qemu-char, io: fix ordering of arguments for UDP socket creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Two wrongs make a right, but they should be fixed anyway. Cc: Daniel P. Berrange Signed-off-by: Paolo Bonzini --- io/channel-socket.c | 2 +- qemu-char.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/io/channel-socket.c b/io/channel-socket.c index 22d2fd6..bf66a78 100644 --- a/io/channel-socket.c +++ b/io/channel-socket.c @@ -258,7 +258,7 @@ int qio_channel_socket_dgram_sync(QIOChannelSocket *ioc, int fd; trace_qio_channel_socket_dgram_sync(ioc, localAddr, remoteAddr); - fd = socket_dgram(localAddr, remoteAddr, errp); + fd = socket_dgram(remoteAddr, localAddr, errp); if (fd < 0) { trace_qio_channel_socket_dgram_fail(ioc); return -1; diff --git a/qemu-char.c b/qemu-char.c index 84eb8a1..2b2c56b 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -4386,7 +4386,7 @@ static CharDriverState *qmp_chardev_open_udp(const char *id, QIOChannelSocket *sioc = qio_channel_socket_new(); if (qio_channel_socket_dgram_sync(sioc, - udp->remote, udp->local, + udp->local, udp->remote, errp) < 0) { object_unref(OBJECT(sioc)); return NULL; -- 2.5.0