qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH 1/1] vl: fix tracing initialization
@ 2016-02-09 16:49 Denis V. Lunev
  2016-02-09 22:20 ` Alex Bennée
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Denis V. Lunev @ 2016-02-09 16:49 UTC (permalink / raw)
  Cc: Denis V. Lunev, Alex Bennée, qemu-devel, Stefan Hajnoczi,
	Paolo Bonzini

we should call trace_init_backends() before trace_init_file() for
CONFIG_TRACE_SIMPLE There is no difference for other cases.

This problem was introduced by the commit
    commit 41fc57e44ed64cd4ab5393d83624afd897dabd4f
    Author: Paolo Bonzini <pbonzini@redhat.com>
    Date:   Thu Jan 7 16:55:24 2016 +0300

    trace: split trace_init_file out of trace_init_backends

'make check' was failed as a result if configured with
  --enable-trace-backends=simple

Spotted by Alex Bennée.

Signed-off-by: Denis V. Lunev <den@openvz.org>
CC: Alex Bennée <alex.bennee@linaro.org>
CC: Paolo Bonzini <pbonzini@redhat.com>
CC: Stefan Hajnoczi <stefanha@redhat.com>
---
 vl.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/vl.c b/vl.c
index c581e39..ffaf8b7 100644
--- a/vl.c
+++ b/vl.c
@@ -4098,6 +4098,9 @@ int main(int argc, char **argv, char **envp)
         exit(0);
     }
 
+    if (!trace_init_backends()) {
+        exit(1);
+    }
     trace_init_file(trace_file);
 
     /* Open the logfile at this point and set the log mask if necessary.
@@ -4118,10 +4121,6 @@ int main(int argc, char **argv, char **envp)
         qemu_set_log(0);
     }
 
-    if (!trace_init_backends()) {
-        exit(1);
-    }
-
     /* If no data_dir is specified then try to find it relative to the
        executable path.  */
     if (data_dir_idx < ARRAY_SIZE(data_dir)) {
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-03-01 13:37 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-09 16:49 [Qemu-devel] [PATCH 1/1] vl: fix tracing initialization Denis V. Lunev
2016-02-09 22:20 ` Alex Bennée
2016-02-10  9:32 ` Christian Borntraeger
2016-02-11 15:45 ` Stefan Hajnoczi
2016-03-01 12:00   ` Christian Borntraeger
2016-03-01 13:36     ` Stefan Hajnoczi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).