From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51243)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prvs=841e7c5e8=Ian.Campbell@citrix.com>)
	id 1aTS2I-0002eL-3a
	for qemu-devel@nongnu.org; Wed, 10 Feb 2016 05:30:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <prvs=841e7c5e8=Ian.Campbell@citrix.com>)
	id 1aTS2E-0002sZ-TC
	for qemu-devel@nongnu.org; Wed, 10 Feb 2016 05:30:14 -0500
Received: from smtp.citrix.com ([66.165.176.89]:56810)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prvs=841e7c5e8=Ian.Campbell@citrix.com>)
	id 1aTS2E-0002r8-OQ
	for qemu-devel@nongnu.org; Wed, 10 Feb 2016 05:30:10 -0500
Message-ID: <1455100205.19857.148.camel@citrix.com>
From: Ian Campbell <ian.campbell@citrix.com>
Date: Wed, 10 Feb 2016 10:30:05 +0000
In-Reply-To: <alpine.DEB.2.02.1602091635460.27008@kaball.uk.xensource.com>
References: <1455034615.19857.96.camel@citrix.com>
	<1455034636-27829-1-git-send-email-ian.campbell@citrix.com>
	<alpine.DEB.2.02.1602091635460.27008@kaball.uk.xensource.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/5] xen: drop support for Xen 4.1 and
	older.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: qemu-devel@nongnu.org, xen-devel@lists.xen.org

On Tue, 2016-02-09 at 16:50 +0000, Stefano Stabellini wrote:
> > @@ -2218,15 +2127,10 @@ EOF
> >=C2=A0 fi
> >=C2=A0=20
> >=C2=A0 if test "$xen_pci_passthrough" !=3D "no"; then
> > -=C2=A0 if test "$xen" =3D "yes" && test "$linux" =3D "yes" &&
> > -=C2=A0=C2=A0=C2=A0 test "$xen_ctrl_version" -ge 340; then
> > +=C2=A0 if test "$xen" =3D "yes" && test "$linux" =3D "yes"; then
> >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 xen_pci_passthrough=3Dyes
> >=C2=A0=C2=A0=C2=A0 else
> >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if test "$xen_pci_passthrough" =3D "yes";=
 then
>=20
> Given that the code has been greatly simplified, I think that we can get
> rid of the test above.

Which one? I think we still need to check for both Linux and Xen being
present and handle users passing --enable-xen-pci-passthrough when those
conditions don't hold.

It might be possible to fold the else if, i.e.=C2=A0

if test "$xen_pci_passthrough" !=3D "no"; then
=C2=A0 if test "$xen" =3D "yes" && test "$linux" =3D "yes"; then
=C2=A0=C2=A0=C2=A0=C2=A0xen_pci_passthrough=3Dyes
=C2=A0 elif test "$xen_pci_passthrough" =3D "yes"; then
=C2=A0 =C2=A0 error_exit "User requested feature Xen PCI Passthrough" \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 " but this feature requires /sys from Linux"
=C2=A0 else
=C2=A0=C2=A0=C2=A0=C2=A0xen_pci_passthrough=3Dno
=C2=A0 fi
fi

?