From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45311) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTUrZ-000190-Vt for qemu-devel@nongnu.org; Wed, 10 Feb 2016 08:31:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTUrV-0007Yo-V0 for qemu-devel@nongnu.org; Wed, 10 Feb 2016 08:31:21 -0500 From: Marcel Apfelbaum Date: Wed, 10 Feb 2016 15:31:11 +0200 Message-Id: <1455111073-5600-1-git-send-email-marcel@redhat.com> Subject: [Qemu-devel] [PATCH V2 0/2] hw/virtio: fix double use of a virtio flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: marcel@redhat.com, lvivier@redhat.com, jasowang@redhat.com, qemu-stable@nongnu.org, mst@redhat.com To the obvious question of "how did that happen?" I can say we had an unlucky break. Both Jason and me worked on a new different virtio feature in the same time, and they were both merged in the same pull request. We both saw BIT 3 as the last used https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg03041.html Commits 1811e64c and a6df8adf use the same virtio feature bit 4 for different features. Fix it by using different bits. While at it, group all the virtio flags into an enum to avoid that in the feature. v1 -> v2: - Addressed Laurent Vivier's comment: - forgot to remove a flag - Added teset-by to the first patch Marcel Apfelbaum (2): hw/virtio: fix double use of a virtio flag hw/virtio: group virtio flags into an enum hw/virtio/virtio-pci.h | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) -- 2.4.3