From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59648) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTxiO-000414-Ba for qemu-devel@nongnu.org; Thu, 11 Feb 2016 15:19:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTxiK-00030v-UG for qemu-devel@nongnu.org; Thu, 11 Feb 2016 15:19:48 -0500 Received: from mailhub.sw.ru ([195.214.232.25]:13366 helo=relay.sw.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTxiK-0002uR-I6 for qemu-devel@nongnu.org; Thu, 11 Feb 2016 15:19:44 -0500 From: "Denis V. Lunev" Date: Thu, 11 Feb 2016 23:19:19 +0300 Message-Id: <1455221959-22728-1-git-send-email-den@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH 1/1] hyperv: cpu hotplug fix with HyperV enabled List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , qemu-devel@nongnu.org, Paolo Bonzini , "Alexey V. Kostyushko" , "Denis V. Lunev" , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Richard Henderson From: "Alexey V. Kostyushko" With Hyper-V enabled CPU hotplug stops working. The CPU appears in device manager on Windows but does not appear in peformance monitor and control panel. The root of the problem is the following. Windows checks HV_X64_CPU_DYNAMIC_PARTITIONING_AVAILABLE bit in CPUID. The presence of this bit is enough to cure the situation. Add option 'hv-cpuhotplug' to control this behavior. Signed-off-by: Alexey V. Kostyushko Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Richard Henderson CC: Eduardo Habkost CC: "Andreas F=C3=A4rber" --- target-i386/cpu-qom.h | 1 + target-i386/cpu.c | 1 + target-i386/kvm.c | 6 +++++- 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/target-i386/cpu-qom.h b/target-i386/cpu-qom.h index 5f9d960..4aec616 100644 --- a/target-i386/cpu-qom.h +++ b/target-i386/cpu-qom.h @@ -96,6 +96,7 @@ typedef struct X86CPU { bool hyperv_runtime; bool hyperv_synic; bool hyperv_stimer; + bool hyperv_cpuhotplug; bool check_cpuid; bool enforce_cpuid; bool expose_kvm; diff --git a/target-i386/cpu.c b/target-i386/cpu.c index b255644..32c38ae 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -3172,6 +3172,7 @@ static Property x86_cpu_properties[] =3D { DEFINE_PROP_BOOL("hv-runtime", X86CPU, hyperv_runtime, false), DEFINE_PROP_BOOL("hv-synic", X86CPU, hyperv_synic, false), DEFINE_PROP_BOOL("hv-stimer", X86CPU, hyperv_stimer, false), + DEFINE_PROP_BOOL("hv-cpuhotplug", X86CPU, hyperv_cpuhotplug, false), DEFINE_PROP_BOOL("check", X86CPU, check_cpuid, true), DEFINE_PROP_BOOL("enforce", X86CPU, enforce_cpuid, false), DEFINE_PROP_BOOL("kvm", X86CPU, expose_kvm, true), diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 94024bc..f4692b9 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -529,7 +529,8 @@ static bool hyperv_enabled(X86CPU *cpu) cpu->hyperv_vpindex || cpu->hyperv_runtime || cpu->hyperv_synic || - cpu->hyperv_stimer); + cpu->hyperv_stimer || + cpu->hyperv_cpuhotplug); } =20 static int kvm_arch_set_tsc_khz(CPUState *cs) @@ -636,6 +637,9 @@ int kvm_arch_init_vcpu(CPUState *cs) c->eax |=3D 0x200; has_msr_hv_tsc =3D true; } + if (cpu->hyperv_cpuhotplug) { + c->edx |=3D HV_X64_CPU_DYNAMIC_PARTITIONING_AVAILABLE; + } if (cpu->hyperv_crash && has_msr_hv_crash) { c->edx |=3D HV_X64_GUEST_CRASH_MSR_AVAILABLE; } --=20 2.1.4