From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34141)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1aVGrQ-0001gF-90
	for qemu-devel@nongnu.org; Mon, 15 Feb 2016 05:58:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1aVGrL-0005Ab-9b
	for qemu-devel@nongnu.org; Mon, 15 Feb 2016 05:58:32 -0500
Received: from mx1.redhat.com ([209.132.183.28]:37033)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1aVGrL-0005AM-4I
	for qemu-devel@nongnu.org; Mon, 15 Feb 2016 05:58:27 -0500
Message-ID: <1455533904.7504.23.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Mon, 15 Feb 2016 11:58:24 +0100
In-Reply-To: <1454840944-29299-3-git-send-email-mst@redhat.com>
References: <1454840944-29299-1-git-send-email-mst@redhat.com>
	<1454840944-29299-3-git-send-email-mst@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/4] pc/q35: drop compatiility with old
 bios types
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>, Marcel Apfelbaum <marcel.a@redhat.com>, John Snow <jsnow@redhat.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Laszlo Ersek <lersek@redhat.com>, Richard Henderson <rth@twiddle.net>

On So, 2016-02-07 at 12:29 +0200, Michael S. Tsirkin wrote:
> We don't ship bios without support for loading ACPI anymore, and old q35
> machine types don't allow migrating such bios.  Drop it, as well as
> has_*mr flags that are there for migration compatibility.

Wouldn't that break migration between 2.5 and 2.6 with -M q35-1.6 ?
It's also a guest-visible change as acpi tables change ...

I'm all for cleaning up this old cruft, but I think it would be cleaner
to just drop the old (pre-migration support) q35 machine types instead
of changing them in subtle ways ...

cheers,
  Gerd