* [Qemu-devel] [PATCH v1 1/1] etraxfs_dma: Dont forward zero-length payload to clients
@ 2016-02-16 11:53 Edgar E. Iglesias
2016-02-19 23:53 ` Edgar E. Iglesias
0 siblings, 1 reply; 2+ messages in thread
From: Edgar E. Iglesias @ 2016-02-16 11:53 UTC (permalink / raw)
To: qemu-devel
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
hw/dma/etraxfs_dma.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/hw/dma/etraxfs_dma.c b/hw/dma/etraxfs_dma.c
index 9cbb165..d5650eb 100644
--- a/hw/dma/etraxfs_dma.c
+++ b/hw/dma/etraxfs_dma.c
@@ -440,13 +440,16 @@ static int channel_out_run(struct fs_dma_ctrl *ctrl, int c)
D(printf("channel %d pushes %x %u bytes eop=%u\n", c,
saved_data_buf, len, out_eop));
- if (ctrl->channels[c].client->client.push)
- ctrl->channels[c].client->client.push(
- ctrl->channels[c].client->client.opaque,
- buf, len, out_eop);
- else
+ if (ctrl->channels[c].client->client.push) {
+ if (len > 0) {
+ ctrl->channels[c].client->client.push(
+ ctrl->channels[c].client->client.opaque,
+ buf, len, out_eop);
+ }
+ } else {
printf("WARNING: DMA ch%d dataloss,"
" no attached client.\n", c);
+ }
saved_data_buf += len;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH v1 1/1] etraxfs_dma: Dont forward zero-length payload to clients
2016-02-16 11:53 [Qemu-devel] [PATCH v1 1/1] etraxfs_dma: Dont forward zero-length payload to clients Edgar E. Iglesias
@ 2016-02-19 23:53 ` Edgar E. Iglesias
0 siblings, 0 replies; 2+ messages in thread
From: Edgar E. Iglesias @ 2016-02-19 23:53 UTC (permalink / raw)
To: qemu-devel
On Tue, Feb 16, 2016 at 12:53:32PM +0100, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
Applied
>
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> ---
> hw/dma/etraxfs_dma.c | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/hw/dma/etraxfs_dma.c b/hw/dma/etraxfs_dma.c
> index 9cbb165..d5650eb 100644
> --- a/hw/dma/etraxfs_dma.c
> +++ b/hw/dma/etraxfs_dma.c
> @@ -440,13 +440,16 @@ static int channel_out_run(struct fs_dma_ctrl *ctrl, int c)
> D(printf("channel %d pushes %x %u bytes eop=%u\n", c,
> saved_data_buf, len, out_eop));
>
> - if (ctrl->channels[c].client->client.push)
> - ctrl->channels[c].client->client.push(
> - ctrl->channels[c].client->client.opaque,
> - buf, len, out_eop);
> - else
> + if (ctrl->channels[c].client->client.push) {
> + if (len > 0) {
> + ctrl->channels[c].client->client.push(
> + ctrl->channels[c].client->client.opaque,
> + buf, len, out_eop);
> + }
> + } else {
> printf("WARNING: DMA ch%d dataloss,"
> " no attached client.\n", c);
> + }
>
> saved_data_buf += len;
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-19 23:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-16 11:53 [Qemu-devel] [PATCH v1 1/1] etraxfs_dma: Dont forward zero-length payload to clients Edgar E. Iglesias
2016-02-19 23:53 ` Edgar E. Iglesias
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).