From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54773)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <abologna@redhat.com>) id 1aVejb-0008Q8-Kd
	for qemu-devel@nongnu.org; Tue, 16 Feb 2016 07:28:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <abologna@redhat.com>) id 1aVejY-00008L-Dc
	for qemu-devel@nongnu.org; Tue, 16 Feb 2016 07:28:03 -0500
Received: from mx1.redhat.com ([209.132.183.28]:41983)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <abologna@redhat.com>) id 1aVejY-00008B-7F
	for qemu-devel@nongnu.org; Tue, 16 Feb 2016 07:28:00 -0500
Message-ID: <1455625675.4617.90.camel@redhat.com>
From: Andrea Bolognani <abologna@redhat.com>
Date: Tue, 16 Feb 2016 13:27:55 +0100
In-Reply-To: <20160216121532.GC11370@redhat.com>
References: <87povy5mim.fsf@blackfin.pond.sub.org>
	<20160215103440.GC7978@pxdev.xzpeter.org>
	<87y4amhuz2.fsf@blackfin.pond.sub.org>
	<CAFEAcA-5JBWtP3FvDLkBh1OGOMfpw2VdZZmFWMaQh1P7DK83jw@mail.gmail.com>
	<87d1rxhid5.fsf@blackfin.pond.sub.org>
	<20160215201815.yheakyujt4axevse@hawk.localdomain>
	<CAFEAcA-oa-6P8W7BzaDBwppGFa0YtSWr9hM4xXXPU=sn9d13MQ@mail.gmail.com>
	<87bn7hufrk.fsf@blackfin.pond.sub.org>
	<20160216101510.GB11370@redhat.com>
	<1455624345.4617.86.camel@redhat.com>
	<20160216121532.GC11370@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [libvirt] [RFC PATCH 0/2] ARM: add QMP command to
 query GIC version
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Wei Huang <wei@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Andrew Jones <drjones@redhat.com>, Libvirt <libvir-list@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Peter Xu <peterx@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On Tue, 2016-02-16 at 12:15 +0000, Daniel P. Berrange wrote:
> On Tue, Feb 16, 2016 at 01:05:45PM +0100, Andrea Bolognani wrote:
> > On Tue, 2016-02-16 at 10:15 +0000, Daniel P. Berrange wrote:
> > > > Back to GIV.=C2=A0=C2=A0Recognized values of gic-version are fixe=
d at compile
> > > > time: 2, 3, host.=C2=A0=C2=A0Once again, QOM does things in code =
rather than data:
> > > > the set of values is defined in the setter function
> > > > virt_set_gic_version().
> > > >=C2=A0=C2=A0
> > > > Some values are accepted only together with other configuration: =
3
> > > > requires accel=3Dkvm (for now), host requires -cpu host.=C2=A0=C2=
=A0Static
> > > > introspection can't show such constraints.
> > > >=C2=A0=C2=A0
> > > > Would the proposed query-gic-capability show them?=C2=A0=C2=A0How=
?
> > >=C2=A0=C2=A0
> > > Also bear in mind that libvirt probes capabilities using '-m none' =
so
> > > you're not going to have any 'virt' machine type instantiated when
> > > probing is done.
> >=C2=A0
> > The idea is to add this information to domain capabilities, which
> > already have virtualization type, architecture and machine type as
> > inputs.
>=C2=A0
> Regardless of the way it is exposed in libvirt API, when libvirt probes
> for capabilities it will *always* use '-m none'.

Domain capabilities are currently derived almost entirely from data
taken from virQEMUCaps, but is there anything stopping us from
calling QEMU with the appropriate machine type from
qemuConnectGetDomainCapabilities() to query for machine type
dependent domain capabilities such as supported values for the
gic-version property?

Cheers.

--=C2=A0
Andrea Bolognani
Software Engineer - Virtualization Team