From: Gerd Hoffmann <kraxel@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: lersek@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] cirrus_vga: fix off-by-one in blit_region_is_unsafe
Date: Tue, 16 Feb 2016 14:30:46 +0100 [thread overview]
Message-ID: <1455629446.7504.91.camel@redhat.com> (raw)
In-Reply-To: <1455121059-18280-1-git-send-email-pbonzini@redhat.com>
On Mi, 2016-02-10 at 17:17 +0100, Paolo Bonzini wrote:
> The "max" value is being compared with >=, but addr + width points to
> the first byte that will _not_ be copied. Laszlo suggested using a
> "greater than" comparison, instead of subtracting one like it is
> already done above for the height, so that max remains always
> positive.
>
> The mistake is "safe"---it will reject some blits, but will never
> cause
> out-of-bounds writes.
added to vga queue.
thanks,
Gerd
prev parent reply other threads:[~2016-02-16 13:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 16:17 [Qemu-devel] [PATCH v2] cirrus_vga: fix off-by-one in blit_region_is_unsafe Paolo Bonzini
2016-02-10 16:54 ` Laszlo Ersek
2016-02-16 13:30 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455629446.7504.91.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).