From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVjra-0003vG-GD for qemu-devel@nongnu.org; Tue, 16 Feb 2016 12:56:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVjrZ-0002oD-MM for qemu-devel@nongnu.org; Tue, 16 Feb 2016 12:56:38 -0500 From: Paolo Bonzini Date: Tue, 16 Feb 2016 18:56:13 +0100 Message-Id: <1455645388-32401-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1455645388-32401-1-git-send-email-pbonzini@redhat.com> References: <1455645388-32401-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 01/16] block: make bdrv_start_throttled_reqs return void List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, stefanha@redhat.com The return value is unused and I am not sure why it would be useful. Signed-off-by: Paolo Bonzini --- block/io.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/block/io.c b/block/io.c index a69bfc4..e58cfe2 100644 --- a/block/io.c +++ b/block/io.c @@ -75,10 +75,8 @@ void bdrv_set_io_limits(BlockDriverState *bs, } } -/* this function drain all the throttled IOs */ -static bool bdrv_start_throttled_reqs(BlockDriverState *bs) +static void bdrv_start_throttled_reqs(BlockDriverState *bs) { - bool drained = false; bool enabled = bs->io_limits_enabled; int i; @@ -86,13 +84,11 @@ static bool bdrv_start_throttled_reqs(BlockDriverState *bs) for (i = 0; i < 2; i++) { while (qemu_co_enter_next(&bs->throttled_reqs[i])) { - drained = true; + ; } } bs->io_limits_enabled = enabled; - - return drained; } void bdrv_io_limits_disable(BlockDriverState *bs) -- 2.5.0