From: Gerd Hoffmann <kraxel@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Peter Crosthwaite <crosthwaitepeter@gmail.com>,
Markus Armbruster <armbru@redhat.com>,
Tim Sander <tim@krieglstein.org>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v6] i2c-tiny-usb: a small usb to i2c bridge
Date: Wed, 17 Feb 2016 17:26:48 +0100 [thread overview]
Message-ID: <1455726408.9127.49.camel@redhat.com> (raw)
In-Reply-To: <87d1rwy4xq.fsf@linaro.org>
On Di, 2016-02-16 at 16:51 +0000, Alex Bennée wrote:
> Tim Sander <tim@krieglstein.org> writes:
>
> > Oh my, so many stupid little errors. Due to firewall impairment i am sending these
> > patches manually. Last time i forgot to disable the newline breaks which made the
> > patch v5 unusable. Sorry for this inconvenience.
"git am" accepts this one, but ...
> Please run ${QEMU_SRC}/scripts/checkpatch.pl on your patch and correct
> the stylistic errors it reports.
... checkpatch.pl indeed throws a bunch of codestyle warnings.
> I'll echo Gerd's comments about the
> value of using git send-email to send patches. If you can glean you
> email clients SMTP settings then you should be able to get
> git-send-email to do this as well.
Yes, you can configure git send-email to use your internal mail server
to send out patches. Best place it in the global config
($HOME/.gitconfig instead of $repo/.git/config) so you don't have to
repeat the procedure for every git tree you have.
Alternatively you can configure a mail daemon such as postfix on your
workstation to deliver mails using your internal mail server as relay.
cheers,
Gerd
next prev parent reply other threads:[~2016-02-17 16:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 15:09 [Qemu-devel] [PATCH RESEND v5] i2c-tiny-usb is a small usb to i2c bridge Tim Sander
2016-02-16 13:42 ` Gerd Hoffmann
2016-02-16 15:55 ` [Qemu-devel] [PATCH v6] i2c-tiny-usb: " Tim Sander
2016-02-16 16:51 ` Alex Bennée
2016-02-17 16:26 ` Gerd Hoffmann [this message]
2016-02-22 8:59 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455726408.9127.49.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=crosthwaitepeter@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tim@krieglstein.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).