From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50992) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW4wH-0006xy-Vq for qemu-devel@nongnu.org; Wed, 17 Feb 2016 11:26:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aW4wE-0007Mh-O5 for qemu-devel@nongnu.org; Wed, 17 Feb 2016 11:26:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51877) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW4wE-0007Lz-IS for qemu-devel@nongnu.org; Wed, 17 Feb 2016 11:26:50 -0500 Message-ID: <1455726408.9127.49.camel@redhat.com> From: Gerd Hoffmann Date: Wed, 17 Feb 2016 17:26:48 +0100 In-Reply-To: <87d1rwy4xq.fsf@linaro.org> References: <2351494.kn6DdoE8y3@dabox> <1455630128.7504.96.camel@redhat.com> <6712401.QIBatU8kCx@dabox> <87d1rwy4xq.fsf@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v6] i2c-tiny-usb: a small usb to i2c bridge List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex =?ISO-8859-1?Q?Benn=E9e?= Cc: Paolo Bonzini , Peter Crosthwaite , Markus Armbruster , Tim Sander , "qemu-devel@nongnu.org Developers" On Di, 2016-02-16 at 16:51 +0000, Alex Benn=C3=A9e wrote: > Tim Sander writes: >=20 > > Oh my, so many stupid little errors. Due to firewall impairment i am se= nding these > > patches manually. Last time i forgot to disable the newline breaks whic= h made the > > patch v5 unusable. Sorry for this inconvenience. "git am" accepts this one, but ... > Please run ${QEMU_SRC}/scripts/checkpatch.pl on your patch and correct > the stylistic errors it reports. ... checkpatch.pl indeed throws a bunch of codestyle warnings. > I'll echo Gerd's comments about the > value of using git send-email to send patches. If you can glean you > email clients SMTP settings then you should be able to get > git-send-email to do this as well. Yes, you can configure git send-email to use your internal mail server to send out patches. Best place it in the global config ($HOME/.gitconfig instead of $repo/.git/config) so you don't have to repeat the procedure for every git tree you have. Alternatively you can configure a mail daemon such as postfix on your workstation to deliver mails using your internal mail server as relay. cheers, Gerd