qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: qemu-devel@nongnu.org
Cc: prem@barefootnetworks.com, daniel@iogearbox.net,
	stefanha@gmail.com, jasowang@redhat.com,
	parag.bhide@barefootnetworks.com, idosch@mellanox.com,
	sfeldma@gmail.com, eladr@mellanox.com, pbonzini@redhat.com,
	alexei.starovoitov@gmail.com
Subject: [Qemu-devel] [patch qemu 3/3] rocker: allow user to specify rocker world by property
Date: Fri, 19 Feb 2016 11:06:43 +0100	[thread overview]
Message-ID: <1455876403-8575-4-git-send-email-jiri@resnulli.us> (raw)
In-Reply-To: <1455876403-8575-1-git-send-email-jiri@resnulli.us>

From: Jiri Pirko <jiri@mellanox.com>

Add property to specify rocker world. All ports will be assigned to this
world.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
 hw/net/rocker/rocker.c | 27 ++++++++++++++++++++++++++-
 1 file changed, 26 insertions(+), 1 deletion(-)

diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c
index a1d921d..d0bdfcb 100644
--- a/hw/net/rocker/rocker.c
+++ b/hw/net/rocker/rocker.c
@@ -43,6 +43,7 @@ struct rocker {
 
     /* switch configuration */
     char *name;                  /* switch name */
+    char *world_name;            /* world name */
     uint32_t fp_ports;           /* front-panel port count */
     NICPeers *fp_ports_peers;
     MACAddr fp_start_macaddr;    /* front-panel port 0 mac addr */
@@ -1286,6 +1287,18 @@ static void rocker_msix_uninit(Rocker *r)
     rocker_msix_vectors_unuse(r, ROCKER_MSIX_VEC_COUNT(r->fp_ports));
 }
 
+static World *rocker_world_type_by_name(Rocker *r, const char *name)
+{
+    int i;
+
+    for (i = 0; i < ROCKER_WORLD_TYPE_MAX; i++) {
+        if (strcmp(name, world_name(r->worlds[i])) == 0) {
+            return r->worlds[i];
+	}
+    }
+    return NULL;
+}
+
 static int pci_rocker_init(PCIDevice *dev)
 {
     Rocker *r = to_rocker(dev);
@@ -1297,7 +1310,18 @@ static int pci_rocker_init(PCIDevice *dev)
     /* allocate worlds */
 
     r->worlds[ROCKER_WORLD_TYPE_OF_DPA] = of_dpa_world_alloc(r);
-    r->world_dflt = r->worlds[ROCKER_WORLD_TYPE_OF_DPA];
+
+    if (!r->world_name) {
+        r->world_name = g_strdup(world_name(r->worlds[ROCKER_WORLD_TYPE_OF_DPA]));
+    }
+
+    r->world_dflt = rocker_world_type_by_name(r, r->world_name);
+    if (!r->world_dflt) {
+        fprintf(stderr,
+                "rocker: requested world \"%s\" does not exist\n",
+                r->world_name);
+        return -EINVAL;
+    }
 
     for (i = 0; i < ROCKER_WORLD_TYPE_MAX; i++) {
         if (!r->worlds[i]) {
@@ -1509,6 +1533,7 @@ static void rocker_reset(DeviceState *dev)
 
 static Property rocker_properties[] = {
     DEFINE_PROP_STRING("name", Rocker, name),
+    DEFINE_PROP_STRING("world", Rocker, world_name),
     DEFINE_PROP_MACADDR("fp_start_macaddr", Rocker,
                         fp_start_macaddr),
     DEFINE_PROP_UINT64("switch_id", Rocker,
-- 
2.4.3

  parent reply	other threads:[~2016-02-19 10:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-19 10:06 [Qemu-devel] [patch qemu 0/3] rocker: prepare for easy addition of other worlds Jiri Pirko
2016-02-19 10:06 ` [Qemu-devel] [patch qemu 1/3] rocker: forbid to change world type Jiri Pirko
2016-02-19 10:06 ` [Qemu-devel] [patch qemu 2/3] rocker: add name field into WorldOps ale let world specify its name Jiri Pirko
2016-02-19 10:06 ` Jiri Pirko [this message]
2016-02-22 17:51   ` [Qemu-devel] [patch qemu 3/3] rocker: allow user to specify rocker world by property Stefan Hajnoczi
2016-02-22 18:06     ` Jiri Pirko
2016-02-25 11:31       ` Stefan Hajnoczi
2016-02-25 11:48         ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455876403-8575-4-git-send-email-jiri@resnulli.us \
    --to=jiri@resnulli.us \
    --cc=alexei.starovoitov@gmail.com \
    --cc=daniel@iogearbox.net \
    --cc=eladr@mellanox.com \
    --cc=idosch@mellanox.com \
    --cc=jasowang@redhat.com \
    --cc=parag.bhide@barefootnetworks.com \
    --cc=pbonzini@redhat.com \
    --cc=prem@barefootnetworks.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sfeldma@gmail.com \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).